Issue 1244044: code review 1244044: big: prevent errors in Exp in the face of aliasing

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1244044: code review 1244044: big: prevent errors in Exp in the face of aliasing (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by agl

Modified:
14 years, 10 months ago

Reviewers:

CC:
gri, golang-dev_golang.org, golang-dev

Visibility:
Public.

Description

big: prevent errors in Exp in the face of aliasing

Patch Set 2 : code review 1244044: big: prevent errors in Exp in the face of aliasing #

Total comments: 1

Patch Set 3 : code review 1244044: big: prevent errors in Exp in the face of aliasing #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
M	src/pkg/big/int.go	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/big/int_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/big/nat.go	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl

Hello gri, gri@golang.org (cc: golang-dev@golang.org, golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 10 months ago (2010-05-24 14:25:15 UTC) #1

gri

LGTM http://codereview.appspot.com/1244044/diff/2001/3003 File src/pkg/big/nat.go (right): http://codereview.appspot.com/1244044/diff/2001/3003#newcode924 src/pkg/big/nat.go:924: // We cannot allow in place modification of ...

14 years, 10 months ago (2010-05-24 17:08:51 UTC) #2

agl

14 years, 10 months ago (2010-05-24 18:33:03 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=b9f88a0c7c7c ***

big: prevent errors in Exp in the face of aliasing

R=gri
CC=golang-dev, golang-dev
http://codereview.appspot.com/1244044

Expand All Messages | Collapse All Messages