Issue 124390043: code review 124390043: go.sys/unix: just jump to syscall.Syscall etc.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 124390043: code review 124390043: go.sys/unix: just jump to syscall.Syscall etc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by r

Modified:
10 years, 7 months ago

Reviewers:
rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

go.sys/unix: just jump to syscall.Syscall etc. Don't re-implement these functions.

Patch Set 1 #

Patch Set 2 : diff -r fcb35749b21684f22dd11fb3b0a76908889b0863 https://code.google.com/p/go.sys #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+110 lines, -1781 lines)			Patch
M	unix/asm_darwin_386.s	View	1 chunk	+7 lines, -122 lines	0 comments	Download
M	unix/asm_darwin_amd64.s	View	1 chunk	+6 lines, -88 lines	0 comments	Download
M	unix/asm_dragonfly_386.s	View	1 chunk	+7 lines, -119 lines	0 comments	Download
M	unix/asm_dragonfly_amd64.s	View	1 chunk	+7 lines, -113 lines	0 comments	Download
M	unix/asm_freebsd_386.s	View	1 chunk	+7 lines, -122 lines	0 comments	Download
M	unix/asm_freebsd_amd64.s	View	1 chunk	+7 lines, -121 lines	0 comments	Download
M	unix/asm_freebsd_arm.s	View	1 chunk	+7 lines, -109 lines	0 comments	Download
M	unix/asm_linux_386.s	View	1 chunk	+11 lines, -164 lines	0 comments	Download
M	unix/asm_linux_amd64.s	View	1 chunk	+7 lines, -106 lines	0 comments	Download
M	unix/asm_linux_arm.s	View	1 chunk	+9 lines, -137 lines	0 comments	Download
M	unix/asm_netbsd_386.s	View	1 chunk	+7 lines, -122 lines	0 comments	Download
M	unix/asm_netbsd_amd64.s	View	1 chunk	+7 lines, -115 lines	0 comments	Download
M	unix/asm_netbsd_arm.s	View	1 chunk	+7 lines, -106 lines	0 comments	Download
M	unix/asm_openbsd_386.s	View	1 chunk	+7 lines, -122 lines	0 comments	Download
M	unix/asm_openbsd_amd64.s	View	1 chunk	+7 lines, -115 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.sys

10 years, 7 months ago (2014-08-14 19:22:00 UTC) #1

10 years, 7 months ago (2014-08-14 19:30:20 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=83b017918783&repo=sys ***

go.sys/unix: just jump to syscall.Syscall etc.
Don't re-implement these functions.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/124390043

Expand All Messages | Collapse All Messages