Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(26)

Issue 12436044: code review 12436044: runtime: use GetQueuedCompletionStatusEx on windows if ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by dvyukov
Modified:
11 years, 7 months ago
Reviewers:
brainman
CC:
golang-dev, brainman
Visibility:
Public.

Description

runtime: use GetQueuedCompletionStatusEx on windows if available GetQueuedCompletionStatusEx allows to dequeue a batch of completion notifications, which is more efficient than dequeueing one by one. benchmark old ns/op new ns/op delta BenchmarkClientServerParallel4 100605 90945 -9.60% BenchmarkClientServerParallel4-2 90225 74504 -17.42%

Patch Set 1 #

Patch Set 2 : diff -r 6423f26d0193 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6423f26d0193 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 6423f26d0193 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 6423f26d0193 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 6423f26d0193 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 7 : diff -r fbc1a650b595 https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r 50c9f3544eed https://go.googlecode.com/hg/ #

Patch Set 9 : diff -r 50c9f3544eed https://go.googlecode.com/hg/ #

Patch Set 10 : diff -r 50c9f3544eed https://go.googlecode.com/hg/ #

Patch Set 11 : diff -r b05fc0deff82 https://go.googlecode.com/hg/ #

Patch Set 12 : diff -r b05fc0deff82 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -32 lines) Patch
M src/pkg/runtime/netpoll.goc View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M src/pkg/runtime/netpoll_windows.c View 1 2 3 4 5 6 7 8 9 3 chunks +68 lines, -32 lines 0 comments Download
M src/pkg/runtime/os_windows.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/runtime/os_windows.c View 1 2 chunks +3 lines, -0 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 7 months ago (2013-08-04 19:28:48 UTC) #1
brainman
I've made some initial comments, but lets land https://codereview.appspot.com/12413043/ before we do proper review. Please, ...
11 years, 7 months ago (2013-08-05 02:59:34 UTC) #2
dvyukov
On 2013/08/05 02:59:34, brainman wrote: > I've made some initial comments, but lets land > ...
11 years, 7 months ago (2013-08-06 13:05:30 UTC) #3
brainman
LGTM Alex
11 years, 7 months ago (2013-08-08 06:39:30 UTC) #4
dvyukov
11 years, 7 months ago (2013-08-08 13:42:13 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=23e06fccd3b9 ***

runtime: use GetQueuedCompletionStatusEx on windows if available
GetQueuedCompletionStatusEx allows to dequeue a batch of completion
notifications, which is more efficient than dequeueing one by one.

benchmark                           old ns/op    new ns/op    delta
BenchmarkClientServerParallel4         100605        90945   -9.60%
BenchmarkClientServerParallel4-2        90225        74504  -17.42%

R=golang-dev, alex.brainman
CC=golang-dev
https://codereview.appspot.com/12436044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b