code review 12436043: runtime: remove unused scheduler knob

runtime: remove unused scheduler knob
Blockingsyscall was used in net package on windows,
it's not used anymore.

[dvyukov, 2013-08-04 16:17:05]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2013-08-04 18:00:43]

LGTM



On Sun, Aug 4, 2013 at 9:17 AM, <dvyukov@google.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> runtime: remove unused scheduler knob
> Blockingsyscall was used in net package on windows,
> it's not used anymore.
>
> Please review this at
https://codereview.appspot.**com/12436043/<https://codereview.appspot.com/124...
>
> Affected files:
>   M src/pkg/runtime/cgocall.c
>   M src/pkg/runtime/runtime.h
>
>
> Index: src/pkg/runtime/cgocall.c
> ==============================**==============================**=======
> --- a/src/pkg/runtime/cgocall.c
> +++ b/src/pkg/runtime/cgocall.c
> @@ -98,15 +98,6 @@
>  static void endcgo(void);
>  static FuncVal endcgoV = { endcgo };
>
> -// Gives a hint that the next syscall
> -// executed by the current goroutine will block.
> -// Currently used only on windows.
> -void
> -net·runtime_**blockingSyscallHint(void)
> -{
> -       g->blockingsyscall = true;
> -}
> -
>  void
>  runtime·cgocall(void (*fn)(void*), void *arg)
>  {
> @@ -158,11 +149,7 @@
>          * so it is safe to call while "in a system call", outside
>          * the $GOMAXPROCS accounting.
>          */
> -       if(g->blockingsyscall) {
> -               g->blockingsyscall = false;
> -               runtime·entersyscallblock();
> -       } else
> -               runtime·entersyscall();
> +       runtime·entersyscall();
>         runtime·asmcgocall(fn, arg);
>         runtime·exitsyscall();
>
> Index: src/pkg/runtime/runtime.h
> ==============================**==============================**=======
> --- a/src/pkg/runtime/runtime.h
> +++ b/src/pkg/runtime/runtime.h
> @@ -269,7 +269,6 @@
>         bool    ispanic;
>         bool    issystem;       // do not output in stack dump
>         bool    isbackground;   // ignore in deadlock detector
> -       bool    blockingsyscall;        // hint that the next syscall will
> block
>         bool    preempt;        // preemption signal, duplicates
> stackguard0 = StackPreempt
>         int8    raceignore;     // ignore race detection events
>         M*      m;              // for debuggers, but offset not hard-coded
> @@ -313,7 +312,6 @@
>         int32   dying;
>         int32   profilehz;
>         int32   helpgc;
> -       bool    blockingsyscall;
>         bool    spinning;
>         uint32  fastrand;
>         uint64  ncgocall;       // number of cgo calls in total
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[dvyukov, 2013-08-04 19:32:51]

*** Submitted as https://code.google.com/p/go/source/detail?r=52e26bb34741 ***

runtime: remove unused scheduler knob
Blockingsyscall was used in net package on windows,
it's not used anymore.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12436043