Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8)

Issue 12424045: code review 12424045: undo CL 12250043 / e911f94c4902 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by dvyukov
Modified:
11 years, 7 months ago
Reviewers:
rsc
CC:
rsc, golang-dev
Visibility:
Public.

Description

undo CL 12250043 / e911f94c4902 Break all 386 builders. ««« original CL description runtime: use gcpc/gcsp during traceback of goroutines in syscalls gcpc/gcsp are used by GC in similar situation. gcpc/gcsp are also more stable than gp->sched, because gp->sched is mutated by entersyscall/exitsyscall in morestack and mcall. So it has higher chances of being inconsistent. Also, rename gcpc/gcsp to syscallpc/syscallsp. R=golang-dev, rsc CC=golang-dev https://codereview.appspot.com/12250043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 0583e9d36ddd https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 0583e9d36ddd https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 0583e9d36ddd https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 0583e9d36ddd https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 0583e9d36ddd https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -32 lines) Patch
M src/pkg/runtime/mgc0.c View 1 1 chunk +5 lines, -5 lines 0 comments Download
M src/pkg/runtime/proc.c View 1 5 chunks +20 lines, -19 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/pkg/runtime/traceback_arm.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/traceback_x86.c View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
dvyukov
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
11 years, 7 months ago (2013-08-05 19:32:35 UTC) #1
dvyukov
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 7 months ago (2013-08-05 19:32:55 UTC) #2
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=ffe930a195f4 *** undo CL 12250043 / e911f94c4902 Break all 386 builders. ««« ...
11 years, 7 months ago (2013-08-05 19:33:58 UTC) #3
rsc
11 years, 7 months ago (2013-08-05 19:49:51 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b