Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(316)

Issue 124150043: code review 124150043: [release-branch.go1.3] include/u.h: define _DEFAULT_SOU... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by adg
Modified:
9 years, 7 months ago
Reviewers:
rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

[release-branch.go1.3] include/u.h: define _DEFAULT_SOURCE for new glibc ««« CL 112530043 / c8059ac4e0ec include/u.h: define _DEFAULT_SOURCE for new glibc glibc devs have apparently decided _BSD_SOURCE will be deprecated on Linux, and issue a preprocessor warning if declaring _BSD_SOURCE without _DEFAULT_SOURCE. https://sourceware.org/glibc/wiki/Release/2.20 Fixes issue 8397. LGTM=iant R=dave, gobot, iant CC=golang-codereviews https://codereview.appspot.com/112530043 Committer: Ian Lance Taylor <iant@golang.org> »»»

Patch Set 1 #

Patch Set 2 : diff -r 16ce5710133e9d4fdbe02f3e3b7a0cfb0b1812bd https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M include/u.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
adg
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 7 months ago (2014-08-11 23:38:15 UTC) #1
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=a10571868491 *** [release-branch.go1.3] include/u.h: define _DEFAULT_SOURCE for new glibc ««« CL 112530043 ...
9 years, 7 months ago (2014-08-11 23:38:35 UTC) #2
rsc
9 years, 7 months ago (2014-08-11 23:55:53 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b