Issue 124140043: code review 124140043: [release-branch.go1.3] net: Don't read beyond end of sl...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 124140043: code review 124140043: [release-branch.go1.3] net: Don't read beyond end of sl... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by adg

Modified:
9 years, 8 months ago

Reviewers:
rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

[release-branch.go1.3] net: Don't read beyond end of slice when parsing resolv.conf options. ««« CL 102470046 / 5207b394de96 net: Don't read beyond end of slice when parsing resolv.conf options. Fixes issue 8252. LGTM=adg R=ruiu, josharian, adg CC=golang-codereviews https://codereview.appspot.com/102470046 Committer: Andrew Gerrand <adg@golang.org> »»»

Patch Set 1 #

Patch Set 2 : diff -r 49a793c2151b6ecaf7be96f17fb61c2e939b0670 https://code.google.com/p/go #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	src/pkg/net/dnsconfig_unix.go	View	1	2 chunks	+7 lines, -3 lines	0 comments	Download
	M	src/pkg/net/testdata/resolv.conf	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 8 months ago (2014-08-11 23:31:28 UTC) #1

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=16ce5710133e *** [release-branch.go1.3] net: Don't read beyond end of slice when parsing ...

9 years, 8 months ago (2014-08-11 23:31:46 UTC) #2

LGTM

Expand All Messages | Collapse All Messages