Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12323)

Issue 124120044: code review 124120044: [release-branch.go1.3] runtime: fix nacl amd64p32 flakiness (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by adg
Modified:
9 years, 8 months ago
Reviewers:
rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

[release-branch.go1.3] runtime: fix nacl amd64p32 flakiness ««« CL 102710043 / 5640e19d768d runtime: fix nacl amd64p32 flakiness newproc takes two extra pointers, not two extra registers. On amd64p32 (nacl) they are different. We diagnosed this before the 1.3 cut but the tree was frozen. I believe this is causing the random problems on the builder. Fixes issue 8199. TBR=r CC=golang-codereviews https://codereview.appspot.com/102710043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 068a94c8700a128736692f284b73b5b2e4961dfa https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/runtime/traceback_x86.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
adg
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 8 months ago (2014-08-11 23:29:22 UTC) #1
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=49a793c2151b *** [release-branch.go1.3] runtime: fix nacl amd64p32 flakiness ««« CL 102710043 / ...
9 years, 8 months ago (2014-08-11 23:29:43 UTC) #2
rsc
9 years, 8 months ago (2014-08-11 23:57:16 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b