code review 12404043: cmd/dist: generate cmd/cgo/zdefaultcc.go on windows (fi...

cmd/dist: generate cmd/cgo/zdefaultcc.go on windows (fixes windows build)

[brainman, 2013-08-03 08:13:26]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[dvyukov, 2013-08-03 08:30:33]

LGTM please land this asap

On Sat, Aug 3, 2013 at 12:13 PM,  <alex.brainman@gmail.com> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/dist: generate cmd/cgo/zdefaultcc.go on windows (fixes windows
> build)
>
> Please review this at https://codereview.appspot.com/12404043/
>
> Affected files:
>   M src/cmd/dist/buildgo.c
>
>
> Index: src/cmd/dist/buildgo.c
> ===================================================================
> --- a/src/cmd/dist/buildgo.c
> +++ b/src/cmd/dist/buildgo.c
> @@ -36,7 +36,10 @@
>         // Convert file name to replace.
>         binit(&b);
>         bwritestr(&b, file);
> -       bsubst(&b, "/go/zdefaultcc.go", "/cgo/zdefaultcc.go");
> +       if(slash[0] == '/')
> +               bsubst(&b, "/go/zdefaultcc.go", "/cgo/zdefaultcc.go");
> +       else
> +               bsubst(&b, "\\go\\zdefaultcc.go", "\\cgo\\zdefaultcc.go");
>         writefile(&out, bstr(&b), 0);
>
>         bfree(&b);
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[r, 2013-08-03 08:30:34]

LGTM

[brainman, 2013-08-03 08:32:25]

*** Submitted as https://code.google.com/p/go/source/detail?r=bf1cd157b3e0 ***

cmd/dist: generate cmd/cgo/zdefaultcc.go on windows (fixes windows build)

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/12404043

[dvyukov, 2013-08-03 08:33:10]

thanks!

On Sat, Aug 3, 2013 at 12:32 PM,  <alex.brainman@gmail.com> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=bf1cd157b3e0 ***
>
>
> cmd/dist: generate cmd/cgo/zdefaultcc.go on windows (fixes windows
> build)
>
> R=golang-dev, r
> CC=golang-dev
> https://codereview.appspot.com/12404043
>
>
>
> https://codereview.appspot.com/12404043/
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>