Issue 12403043: code review 12403043: flag: document the zero value of FlagSet

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12403043: code review 12403043: flag: document the zero value of FlagSet (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by Kyle E. Lemons

Modified:
11 years, 7 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

flag: document the zero value of FlagSet

Patch Set 2 : diff -r 0c05398daad8 http://code.google.com/p/go #

Patch Set 3 : diff -r 0c05398daad8 http://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 0c05398daad8 http://code.google.com/p/go #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
	M	src/pkg/flag/flag.go	View	1 2 3	3 chunks	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Kyle E. Lemons

Hello golang-dev, r (cc: golang-dev@googlegroups.com), I'd like you to review this change to http://code.google.com/p/go

11 years, 7 months ago (2013-08-03 07:13:08 UTC) #1

https://codereview.appspot.com/12403043/diff/5001/src/pkg/flag/flag.go File src/pkg/flag/flag.go (right): https://codereview.appspot.com/12403043/diff/5001/src/pkg/flag/flag.go#newcode261 src/pkg/flag/flag.go:261: // error handling. instead, say what the zero value ...

11 years, 7 months ago (2013-08-03 07:44:25 UTC) #2

Kyle E. Lemons

Thanks, PTAL https://codereview.appspot.com/12403043/diff/5001/src/pkg/flag/flag.go File src/pkg/flag/flag.go (right): https://codereview.appspot.com/12403043/diff/5001/src/pkg/flag/flag.go#newcode261 src/pkg/flag/flag.go:261: // error handling. On 2013/08/03 07:44:25, r ...

11 years, 7 months ago (2013-08-06 05:23:00 UTC) #3

11 years, 7 months ago (2013-08-06 06:48:28 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=6294f3ca30e1 ***

flag: document the zero value of FlagSet

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/12403043

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages