Issue 1240044: code review 1240044: go/printer, gofmt: fix printing of labels,

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1240044: code review 1240044: go/printer, gofmt: fix printing of labels, (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by gri

Modified:
14 years, 10 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

go/printer, gofmt: fix printing of labels, apply gofmt to src, misc Fixes issue 752.

Patch Set 1 #

Patch Set 2 : code review 1240044: go/printer, gofmt: fix printing of labels, #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -26 lines)			Patch
M	src/pkg/exp/draw/draw_test.go	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/fmt/print.go	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/go/parser/parser.go	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/go/printer/nodes.go	View	1 chunk	+9 lines, -6 lines	0 comments	Download
M	src/pkg/go/printer/testdata/statements.golden	View	5 chunks	+30 lines, -15 lines	0 comments	Download
M	src/pkg/go/printer/testdata/statements.input	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/pkg/net/ip.go	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/reflect/type.go	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 10 months ago (2010-05-21 23:56:54 UTC) #1

rsc1

LGTM I like that the grammar's semicolon rules make switch { Foo: case 1: bar() ...

14 years, 10 months ago (2010-05-22 00:39:01 UTC) #2

gri

14 years, 10 months ago (2010-05-22 03:25:19 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=baf75e1c5625 ***

go/printer, gofmt: fix printing of labels,
apply gofmt to src, misc

Fixes issue 752.

R=rsc
CC=golang-dev
http://codereview.appspot.com/1240044

Committer: Robert Griesemer <gri@golang.org>

Expand All Messages | Collapse All Messages