Issue 12397043: code review 12397043: net/http: Various fixes to Basic authentication

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12397043: code review 12397043: net/http: Various fixes to Basic authentication (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by peted

Modified:
10 years, 9 months ago

Reviewers:
bradfitz

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

net/http: Various fixes to Basic authentication There were some issues with the code sometimes using base64.StdEncoding, and sometimes base64.URLEncoding. Encoding basic authentication is now always done by the same code. Should it encoding/decoding perhaps be in net/url, as a method on Userinfo? Fixes issue 5970.

Patch Set 1 #

Patch Set 2 : diff -r 7c06f390d1ad https://code.google.com/p/go #

Patch Set 3 : diff -r 7c06f390d1ad https://code.google.com/p/go #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -19 lines)			Patch
M	src/pkg/net/http/client.go	View	1	2 chunks	+13 lines, -12 lines	0 comments	Download
M	src/pkg/net/http/client_test.go	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download
M	src/pkg/net/http/request.go	View	1	2 chunks	+1 line, -3 lines	0 comments	Download
M	src/pkg/net/http/transport.go	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/pkg/net/url/url.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

peted

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 9 months ago (2013-08-03 04:16:11 UTC) #1

bradfitz

10 years, 9 months ago (2013-08-07 18:59:03 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=06da2934c103 ***

net/http: Various fixes to Basic authentication

There were some issues with the code sometimes using base64.StdEncoding,
and sometimes base64.URLEncoding.
Encoding basic authentication is now always done by the same code.

Fixes issue 5970.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12397043

Committer: Brad Fitzpatrick <bradfitz@golang.org>

Expand All Messages | Collapse All Messages