Issue 12387044: code review 12387044: compress/bzip2: support concatenated files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12387044: code review 12387044: compress/bzip2: support concatenated files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by rsc

Modified:
11 years, 7 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

compress/bzip2: support concatenated files While we're here, add a test for the same functionality in gzip, which was already implemented, and add bzip2 CRC checks. Fixes issue 5772.

Patch Set 2 : diff -r 5cdc93018bcf https://code.google.com/p/go/ #

Patch Set 3 : diff -r 5cdc93018bcf https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r 5cdc93018bcf https://code.google.com/p/go/ #

Patch Set 5 : diff -r 5cdc93018bcf https://code.google.com/p/go/ #

Patch Set 6 : diff -r f92a80e2ed16 https://code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+159 lines, -38 lines)			Patch
M	src/pkg/compress/bzip2/bzip2.go	View	1 2 3 4	7 chunks	+129 lines, -38 lines	0 comments	Download
M	src/pkg/compress/bzip2/bzip2_test.go	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/pkg/compress/gzip/gzip_test.go	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 7 months ago (2013-08-03 00:47:02 UTC) #1

LGTM https://codereview.appspot.com/12387044/diff/5001/src/pkg/compress/bzip2/bzip2.go File src/pkg/compress/bzip2/bzip2.go (right): https://codereview.appspot.com/12387044/diff/5001/src/pkg/compress/bzip2/bzip2.go#newcode223 src/pkg/compress/bzip2/bzip2.go:223: goto Top i'd recur but in any case ...

11 years, 7 months ago (2013-08-03 02:22:04 UTC) #2

rsc

PTAL https://codereview.appspot.com/12387044/diff/5001/src/pkg/compress/bzip2/bzip2.go File src/pkg/compress/bzip2/bzip2.go (right): https://codereview.appspot.com/12387044/diff/5001/src/pkg/compress/bzip2/bzip2.go#newcode223 src/pkg/compress/bzip2/bzip2.go:223: goto Top On 2013/08/03 02:22:04, r wrote: > ...

11 years, 7 months ago (2013-08-03 02:38:51 UTC) #3

rsc

11 years, 7 months ago (2013-08-05 20:08:11 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=37c781077143 ***

compress/bzip2: support concatenated files

While we're here, add a test for the same functionality in gzip,
which was already implemented, and add bzip2 CRC checks.

Fixes issue 5772.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/12387044

Expand All Messages | Collapse All Messages