Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(599)

Issue 12372043: code review 12372043: cmd/dist: fix build again (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by rsc
Modified:
11 years, 7 months ago
Reviewers:
bradfitz
CC:
bradfitz, golang-dev
Visibility:
Public.

Description

cmd/dist: fix build again I am really bad at this. Didn't hg add this file.

Patch Set 1 #

Patch Set 2 : diff -r 0f70059daaf1 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 0f70059daaf1 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
A src/cmd/dist/buildgo.c View 1 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello bradfitz (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 7 months ago (2013-08-02 19:20:40 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=5cdc93018bcf *** cmd/dist: fix build again I am really bad at this. ...
11 years, 7 months ago (2013-08-02 19:20:45 UTC) #2
bradfitz
LGTM Does this need to be added to hgignore too, like the runtime z files? ...
11 years, 7 months ago (2013-08-02 19:59:07 UTC) #3
rsc
11 years, 7 months ago (2013-08-03 01:34:20 UTC) #4
Yes, CL sent.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b