Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2447)

Issue 123700044: code review 123700044: runtime: convert timers to Go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by dvyukov
Modified:
10 years, 6 months ago
Reviewers:
gobot, rsc
CC:
golang-codereviews, ruiu, rsc, DMorsing, khr
Visibility:
Public.

Description

runtime: convert timers to Go

Patch Set 1 #

Patch Set 2 : diff -r d290f48255fb933439916159ecd5301c5bb5c301 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r d290f48255fb933439916159ecd5301c5bb5c301 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r d290f48255fb933439916159ecd5301c5bb5c301 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r c72521f4230dc3aa270e6c232928094446e3bce6 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 42bcf6ae4aff0511890d4fe35aa15f14b7b751c8 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 7 : diff -r 42bcf6ae4aff0511890d4fe35aa15f14b7b751c8 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 8 : diff -r d1f610e29700e8feacb59c227c209a6c02b6c84c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 9 : diff -r d1f610e29700e8feacb59c227c209a6c02b6c84c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 10 : diff -r d1f610e29700e8feacb59c227c209a6c02b6c84c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 11 : diff -r fd0a30a51d14a8a429ad72fdb5d13f7085d56d01 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 12 : diff -r fd0a30a51d14a8a429ad72fdb5d13f7085d56d01 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 13 : diff -r fd0a30a51d14a8a429ad72fdb5d13f7085d56d01 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 14 : diff -r 6fef61428b51f5f500167208a1985d5a2234a6c0 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 14

Patch Set 15 : diff -r bebfeba1e59da4d4570048e941743ae2452690d9 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 16 : diff -r bebfeba1e59da4d4570048e941743ae2452690d9 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 21

Patch Set 17 : diff -r c29860623fb3ba526147d39e85617c7750913aa3 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 18 : diff -r c29860623fb3ba526147d39e85617c7750913aa3 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 19 : diff -r c29860623fb3ba526147d39e85617c7750913aa3 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 20 : diff -r 3f13ed48b37ed52cd347d23aa321f81a4ec2c44d https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -300 lines) Patch
M src/pkg/runtime/mgc0.c View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +10 lines, -0 lines 0 comments Download
M src/pkg/runtime/netpoll.goc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +15 lines, -0 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 3 chunks +0 lines, -33 lines 0 comments Download
M src/pkg/runtime/thunk.s View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +12 lines, -0 lines 0 comments Download
M src/pkg/runtime/time.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +187 lines, -265 lines 0 comments Download
M src/pkg/syscall/net_nacl.go View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/time/sleep.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14
dvyukov
Hello golang-codereviews@googlegroups.com (cc: khr@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 6 months ago (2014-08-22 18:07:02 UTC) #1
ruiu
I don't have enough knowledge on this code so take the comments with a grain ...
10 years, 6 months ago (2014-08-23 20:41:40 UTC) #2
dvyukov
PTAL https://codereview.appspot.com/123700044/diff/260001/src/pkg/runtime/mgc0.c File src/pkg/runtime/mgc0.c (right): https://codereview.appspot.com/123700044/diff/260001/src/pkg/runtime/mgc0.c#newcode2117 src/pkg/runtime/mgc0.c:2117: On 2014/08/23 20:41:40, ruiu wrote: > remove this ...
10 years, 6 months ago (2014-08-24 16:28:18 UTC) #3
rsc
LGTM https://codereview.appspot.com/123700044/diff/290001/src/pkg/runtime/netpoll.goc File src/pkg/runtime/netpoll.goc (right): https://codereview.appspot.com/123700044/diff/290001/src/pkg/runtime/netpoll.goc#newcode42 src/pkg/runtime/netpoll.goc:42: // time.go knows the layout of this structure. ...
10 years, 6 months ago (2014-08-24 18:43:26 UTC) #4
dvyukov
https://codereview.appspot.com/123700044/diff/290001/src/pkg/runtime/netpoll.goc File src/pkg/runtime/netpoll.goc (right): https://codereview.appspot.com/123700044/diff/290001/src/pkg/runtime/netpoll.goc#newcode42 src/pkg/runtime/netpoll.goc:42: // time.go knows the layout of this structure. On ...
10 years, 6 months ago (2014-08-25 11:43:31 UTC) #5
dvyukov
On 2014/08/24 18:43:26, rsc wrote: > LGTM Russ, please check siftdownTimer call in timerproc. I ...
10 years, 6 months ago (2014-08-25 11:44:34 UTC) #6
dvyukov
https://codereview.appspot.com/123700044/diff/290001/src/pkg/runtime/time.go File src/pkg/runtime/time.go (right): https://codereview.appspot.com/123700044/diff/290001/src/pkg/runtime/time.go#newcode1 src/pkg/runtime/time.go:1: // Copyright 2014 The Go Authors. All rights reserved. ...
10 years, 6 months ago (2014-08-25 11:52:03 UTC) #7
DMorsing
On 2014/08/25 11:52:03, dvyukov wrote: > https://codereview.appspot.com/123700044/diff/290001/src/pkg/runtime/time.go#newcode48 > src/pkg/runtime/time.go:48: t := new(timer) > On 2014/08/24 ...
10 years, 6 months ago (2014-08-25 13:37:33 UTC) #8
dvyukov
On 2014/08/25 13:37:33, DMorsing wrote: > On 2014/08/25 11:52:03, dvyukov wrote: > > > https://codereview.appspot.com/123700044/diff/290001/src/pkg/runtime/time.go#newcode48 ...
10 years, 6 months ago (2014-08-25 13:43:08 UTC) #9
DMorsing
On 2014/08/25 13:43:08, dvyukov wrote: > On 2014/08/25 13:37:33, DMorsing wrote: > > On 2014/08/25 ...
10 years, 6 months ago (2014-08-25 13:54:45 UTC) #10
dvyukov
On 2014/08/25 11:44:34, dvyukov wrote: > On 2014/08/24 18:43:26, rsc wrote: > > LGTM > ...
10 years, 6 months ago (2014-08-25 16:17:03 UTC) #11
rsc
LGTM You're right about siftdownTimer. My reasoning was that the C code didn't have the ...
10 years, 6 months ago (2014-08-25 16:18:31 UTC) #12
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=1b51bfe61c6d *** runtime: convert timers to Go LGTM=rsc R=golang-codereviews, ruiu, rsc, daniel.morsing ...
10 years, 6 months ago (2014-08-25 16:25:28 UTC) #13
gobot
10 years, 6 months ago (2014-08-26 02:09:54 UTC) #14
Message was sent while issue was closed.
This CL appears to have broken the nacl-amd64p32 builder.
See http://build.golang.org/log/7a4cbaded34ea1a3a98622a15208f0af73529062
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b