code review 12349044: os, syscall: implement Getwd on darwin using getattrlist

os, syscall: implement Getwd on darwin using getattrlist

Fixes issue 4807

[bradfitz, 2013-08-05 17:48:21]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2013-08-05 17:57:00]

It's not clear to me that the wrapping of GetAttrList is terribly useful by
itself. Maybe we can make that part unexported and just implement
syscall.Getwd?

Russ

[bradfitz, 2013-08-05 18:04:21]

Works for me.



On Mon, Aug 5, 2013 at 10:56 AM, Russ Cox <rsc@golang.org> wrote:

> It's not clear to me that the wrapping of GetAttrList is terribly useful
> by itself. Maybe we can make that part unexported and just implement
> syscall.Getwd?
>
> Russ
>
>

[bradfitz, 2013-08-05 18:20:17]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-08-05 18:26:43]

Done. PTAL.



On Mon, Aug 5, 2013 at 11:04 AM, Brad Fitzpatrick <bradfitz@golang.org>wrote:

> Works for me.
>
>
>
> On Mon, Aug 5, 2013 at 10:56 AM, Russ Cox <rsc@golang.org> wrote:
>
>> It's not clear to me that the wrapping of GetAttrList is terribly useful
>> by itself. Maybe we can make that part unexported and just implement
>> syscall.Getwd?
>>
>> Russ
>>
>>
>

[rsc, 2013-08-05 19:01:44]

LGTM

Thanks very much.

https://codereview.appspot.com/12349044/diff/12001/src/pkg/syscall/syscall_bs...
File src/pkg/syscall/syscall_bsd_no_getwd.go (right):

https://codereview.appspot.com/12349044/diff/12001/src/pkg/syscall/syscall_bs...
src/pkg/syscall/syscall_bsd_no_getwd.go:1: // Copyright 2013 The Go Authors. All
rights reserved.
name this file syscall_no_getwd.go

[bradfitz, 2013-08-05 19:26:09]

*** Submitted as https://code.google.com/p/go/source/detail?r=0583e9d36ddd ***

os, syscall: implement Getwd on darwin using getattrlist

Fixes issue 4807

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/12349044