Issue 12332043: code review 12332043: syscall: fix IPv6 wrong network mask on latest FreeBSD

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12332043: code review 12332043: syscall: fix IPv6 wrong network mask on latest FreeBSD (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by mikio

Modified:
11 years, 7 months ago

Reviewers:
bradfitz

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

syscall: fix IPv6 wrong network mask on latest FreeBSD Looks like latest FreeBSD doesn't set address family identifer for RTAX_NETMASK stuff; probably RTAX_GENMASK too, not confirmed. This CL tries to identify address families by using the length of each socket address if possible. The issue is confirmed on FreeBSD 9.1.

Patch Set 1 #

Patch Set 2 : diff -r 8b61a4ec6d1e https://code.google.com/p/go #

Patch Set 3 : diff -r 8b61a4ec6d1e https://code.google.com/p/go #

Patch Set 4 : diff -r 1169c3ec0059 https://code.google.com/p/go #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -2 lines)			Patch
	M	src/pkg/net/interface_test.go	View	1	1 chunk	+12 lines, -1 line	0 comments	Download
	M	src/pkg/syscall/route_bsd.go	View	1	1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 7 months ago (2013-08-02 08:28:17 UTC) #1

bradfitz

LGTM On Mon, Aug 5, 2013 at 11:35 PM, <mikioh.mikioh@gmail.com> wrote: > ping > > ...

11 years, 7 months ago (2013-08-06 15:00:59 UTC) #3

mikio

11 years, 7 months ago (2013-08-06 15:25:30 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=3cde0ba2c729 ***

syscall: fix IPv6 wrong network mask on latest FreeBSD

Looks like latest FreeBSD doesn't set address family identifer
for RTAX_NETMASK stuff; probably RTAX_GENMASK too, not confirmed.
This CL tries to identify address families by using the length of
each socket address if possible.

The issue is confirmed on FreeBSD 9.1.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12332043

Expand All Messages | Collapse All Messages