Issue 123290043: [dev.power64] code review 123290043: syscall: script changes for power64

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 123290043: [dev.power64] code review 123290043: syscall: script changes for power64 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by minux

Modified:
10 years, 7 months ago

Reviewers:
rsc

CC:
rsc, iant, golang-codereviews

Visibility:
Public.

Patch Set 2 : diff -r 374c2eb01bdb2388e0291ae405439c3c0990ff9c https://code.google.com/p/go #

Patch Set 3 : diff -r 374c2eb01bdb2388e0291ae405439c3c0990ff9c https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 374c2eb01bdb2388e0291ae405439c3c0990ff9c https://code.google.com/p/go #

Patch Set 5 : diff -r 4a21ca18b77fb20da2ed2eab87966b052684381c https://code.google.com/p/go #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -2 lines)			Patch
	M	src/pkg/syscall/mkall.sh	View	1 2 3	4 chunks	+17 lines, -2 lines	0 comments	Download
	M	src/pkg/syscall/mkerrors.sh	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

minux

Hello rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.power64 ...

10 years, 7 months ago (2014-08-12 19:08:24 UTC) #1

rsc

https://codereview.appspot.com/123290043/diff/40001/src/pkg/syscall/mkall.sh File src/pkg/syscall/mkall.sh (right): https://codereview.appspot.com/123290043/diff/40001/src/pkg/syscall/mkall.sh#newcode179 src/pkg/syscall/mkall.sh:179: linux_power64) This could add GOOSARCH=linux_power64x and similarly in the ...

10 years, 7 months ago (2014-08-12 19:27:02 UTC) #2

minux

Hello rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.

10 years, 7 months ago (2014-08-12 21:59:38 UTC) #3

minux

10 years, 7 months ago (2014-08-12 23:49:34 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=03d0e277d52b ***

[dev.power64] syscall: script changes for power64

LGTM=rsc
R=rsc, iant
CC=golang-codereviews
https://codereview.appspot.com/123290043

Expand All Messages | Collapse All Messages