code review 123010044: go/parser: don't do method receiver checks at parse-time

go/parser: don't do method receiver checks at parse-time

The ast and printer don't care, and go/types can provide
a better error message.

This change requires an update to the tests for go/types
(go.tools repo). CL forthcoming.

Fixes issue 8493.

[gri, 2014-08-07 16:52:47]

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[adonovan, 2014-08-07 17:51:31]

On 2014/08/07 16:52:47, gri wrote:
> Hello mailto:rsc@golang.org (cc: mailto:golang-codereviews@googlegroups.com),
> 
> I'd like you to review this change to
> https://code.google.com/p/go/

Will vet, golint, etc, care, or do they all use go/types now?

[gri, 2014-08-07 17:55:16]

go vet passes tests. I don't know that they checked this before. Perhaps
they should check now if they don't use go/types. Can be fixed separately.


On Thu, Aug 7, 2014 at 10:51 AM, <adonovan@google.com> wrote:

> On 2014/08/07 16:52:47, gri wrote:
>
>> Hello mailto:rsc@golang.org (cc:
>>
> mailto:golang-codereviews@googlegroups.com),
>
>
>  I'd like you to review this change to
>> https://code.google.com/p/go/
>>
>
> Will vet, golint, etc, care, or do they all use go/types
> <https://goto.google.com/types> now?
>
> https://codereview.appspot.com/123010044/
>

[adonovan, 2014-08-07 19:29:09]

On 2014/08/07 17:55:16, gri wrote:
> go vet passes tests. I don't know that they checked this before. Perhaps
> they should check now if they don't use go/types. Can be fixed separately.
> 
> 
> On Thu, Aug 7, 2014 at 10:51 AM, <mailto:adonovan@google.com> wrote:
> 
> > On 2014/08/07 16:52:47, gri wrote:
> >
> >> Hello mailto:rsc@golang.org (cc:
> >>
> > mailto:golang-codereviews@googlegroups.com),
> >
> >
> >  I'd like you to review this change to
> >> https://code.google.com/p/go/
> >>
> >
> > Will vet, golint, etc, care, or do they all use go/types
> > <https://goto.google.com/types> now?
> >
> > https://codereview.appspot.com/123010044/
> >

LGTM

[gri, 2014-08-07 19:45:04]

*** Submitted as https://code.google.com/p/go/source/detail?r=179dc6045b9e ***

go/parser: don't do method receiver checks at parse-time

The ast and printer don't care, and go/types can provide
a better error message.

This change requires an update to the tests for go/types
(go.tools repo). CL forthcoming.

Fixes issue 8493.

LGTM=adonovan
R=rsc, adonovan
CC=golang-codereviews
https://codereview.appspot.com/123010044