code review 122960043: encoding/xml: add InputOffset method to Decoder

encoding/xml: add InputOffset method to Decoder

Among other things, this allows users to match the decoded
pieces with the original XML, which can be necessary for
implementing standards like XML signatures.

Fixes issue 8484.

[bradfitz, 2014-08-06 16:53:13]

LGTM

test?

[rsc, 2014-08-06 18:27:09]

I'll add a test before I send it for review. :-)

[rsc, 2014-08-06 21:05:10]

Hello bradfitz@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2014-08-06 21:10:10]

LGTM

[rsc, 2014-08-06 22:00:10]

*** Submitted as https://code.google.com/p/go/source/detail?r=18c464e4811e ***

encoding/xml: add InputOffset method to Decoder

Among other things, this allows users to match the decoded
pieces with the original XML, which can be necessary for
implementing standards like XML signatures.

Fixes issue 8484.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://codereview.appspot.com/122960043

[gobot, 2014-08-06 22:39:01]

This CL appears to have broken the nacl-arm builder.
See http://build.golang.org/log/6dac54b5cb4d1abac23959e70e4bc050d477d1ec

[dave_cheney.net, 2014-08-06 22:54:08]

I'm guessing these exit 255 errors are the build being cancelled manually?
On 7 Aug 2014 08:39, <gobot@golang.org> wrote:

> This CL appears to have broken the nacl-arm builder.
> See http://build.golang.org/log/6dac54b5cb4d1abac23959e70e4bc050d477d1ec
>
> https://codereview.appspot.com/122960043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[r, 2014-08-06 23:33:52]

go1.4.txt please