Issue 12288043: code review 12288043: compress/flate: Fixed two panics on bad data

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12288043: code review 12288043: compress/flate: Fixed two panics on bad data (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by peted

Modified:
10 years, 9 months ago

Reviewers:
bradfitz

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

compress/flate: Fixed two panics on bad data I used just enough of the data provided by Matt in Issue 5915 to trigger issue 5915. As luck would have it, using slightly less of it triggered issue 5962. Fixes issue 5915. Fixes issue 5962.

Patch Set 1 #

Patch Set 2 : diff -r 65920aec044a https://code.google.com/p/go #

Patch Set 3 : diff -r 65920aec044a https://code.google.com/p/go #

Patch Set 4 : diff -r 65920aec044a https://code.google.com/p/go #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -1 line)			Patch
	M	src/pkg/compress/flate/flate_test.go	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download
	M	src/pkg/compress/flate/inflate.go	View	1 2	2 chunks	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

peted

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 9 months ago (2013-08-01 21:58:10 UTC) #1

bradfitz

10 years, 9 months ago (2013-08-01 22:20:04 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=a8f21dd4c92e ***

compress/flate: Fixed two panics on bad data

I used just enough of the data provided by Matt in Issue 5915 to trigger
issue 5915. As luck would have it, using slightly less of it triggered
issue 5962.

Fixes issue 5915.
Fixes issue 5962.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12288043

Committer: Brad Fitzpatrick <bradfitz@golang.org>

Expand All Messages | Collapse All Messages