code review 12271043: go.talks: handle scrolling events to navigate slides

go.talks: handle scrolling events to navigate slides

[francesc, 2013-08-01 17:41:42]

Hello r@golang.org, adg@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.talks

[r, 2013-08-06 22:51:40]

seems fine if it behaves as advertised. leaving for adg.

thanks for this.

[adg, 2013-08-12 05:41:36]

https://codereview.appspot.com/12271043/diff/10001/present/static/slides.js
File present/static/slides.js (right):

https://codereview.appspot.com/12271043/diff/10001/present/static/slides.js#n...
present/static/slides.js:310: var delta = event.detail ? -120*event.detail :
event.wheelDelta;
should this be the other way around? check for wheelDelta first, and fall back
on detail?

[francesc, 2013-08-12 20:46:29]

https://codereview.appspot.com/12271043/diff/10001/present/static/slides.js
File present/static/slides.js (right):

https://codereview.appspot.com/12271043/diff/10001/present/static/slides.js#n...
present/static/slides.js:310: var delta = event.detail ? -120*event.detail :
event.wheelDelta;
On 2013/08/12 05:41:36, adg wrote:
> should this be the other way around? check for wheelDelta first, and fall back
> on detail?

Done.

[adg, 2013-08-12 23:39:11]

https://codereview.appspot.com/12271043/diff/17001/present/static/slides.js
File present/static/slides.js (right):

https://codereview.appspot.com/12271043/diff/17001/present/static/slides.js#n...
present/static/slides.js:310: var delta = event.wheelDelta ? event.wheelDelta :
-event.detail;
why -event.detail here, but -120*event.detail in the previous one?

[francesc, 2013-08-12 23:51:49]

https://codereview.appspot.com/12271043/diff/17001/present/static/slides.js
File present/static/slides.js (right):

https://codereview.appspot.com/12271043/diff/17001/present/static/slides.js#n...
present/static/slides.js:310: var delta = event.wheelDelta ? event.wheelDelta :
-event.detail;
On 2013/08/12 23:39:11, adg wrote:
> why -event.detail here, but -120*event.detail in the previous one?

Because we only care about the sign, not the magnitude.

[adg, 2013-08-12 23:57:36]

LGTM

[francesc, 2013-08-12 23:59:07]

*** Submitted as
https://code.google.com/p/go/source/detail?r=52aa98a44b8c&repo=talks ***

go.talks: handle scrolling events to navigate slides

R=r, adg
CC=golang-dev
https://codereview.appspot.com/12271043