code review 12261044: testing: make parsing of -cpu more lenient

testing: make parsing of -cpu more lenient

Also add \n to error message.

[rsc, 2013-08-02 16:07:26]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-08-02 16:15:31]

LGTM



On Fri, Aug 2, 2013 at 9:07 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> testing: make parsing of -cpu more lenient
>
> Also add \n to error message.
>
> Please review this at
https://codereview.appspot.**com/12261044/<https://codereview.appspot.com/122...
>
> Affected files:
>   M src/pkg/testing/testing.go
>
>
> Index: src/pkg/testing/testing.go
> ==============================**==============================**=======
> --- a/src/pkg/testing/testing.go
> +++ b/src/pkg/testing/testing.go
> @@ -575,16 +575,19 @@
>  }
>
>  func parseCpuList() {
> -       if len(*cpuListStr) == 0 {
> +       for _, val := range strings.Split(*cpuListStr, ",") {
> +               val = strings.TrimSpace(val)
> +               if val == "" {
> +                       continue
> +               }
> +               cpu, err := strconv.Atoi(val)
> +               if err != nil || cpu <= 0 {
> +                       fmt.Fprintf(os.Stderr, "testing: invalid value %q
> for -test.cpu\n", val)
> +                       os.Exit(1)
> +               }
> +               cpuList = append(cpuList, cpu)
> +       }
> +       if cpuList == nil {
>                 cpuList = append(cpuList, runtime.GOMAXPROCS(-1))
> -       } else {
> -               for _, val := range strings.Split(*cpuListStr, ",") {
> -                       cpu, err := strconv.Atoi(val)
> -                       if err != nil || cpu <= 0 {
> -                               fmt.Fprintf(os.Stderr, "testing: invalid
> value %q for -test.cpu", val)
> -                               os.Exit(1)
> -                       }
> -                       cpuList = append(cpuList, cpu)
> -               }
>         }
>  }
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[rsc, 2013-08-02 17:51:50]

*** Submitted as https://code.google.com/p/go/source/detail?r=ef69e6cf3bd0 ***

testing: make parsing of -cpu more lenient

Also add \n to error message.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12261044