Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(75)

Issue 122600043: code review 122600043: go.sys/windows: use syscall.Errno for windows errors (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by r
Modified:
10 years, 6 months ago
Reviewers:
brainman, rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

go.sys/windows: use syscall.Errno for windows errors If we use a local type, it won't compare properly with errors from the rest of the standard library. Errors are the one type from syscall that propagates through the system, so it's important to have only one type for them. mkerrors_windows.sh is gone, so: - rename zerrors_windows.go and delete its DO NOT EDIT mark - delete the contentless zerrors_windows_*.go files

Patch Set 1 #

Patch Set 2 : diff -r 8064e8e8859364272ec8484dbcd1f781a93d1065 https://code.google.com/p/go.sys #

Patch Set 3 : diff -r 8064e8e8859364272ec8484dbcd1f781a93d1065 https://code.google.com/p/go.sys #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -84 lines) Patch
M windows/errors_windows.go View 2 chunks +8 lines, -5 lines 0 comments Download
M windows/mksyscall_windows.go View 2 chunks +2 lines, -2 lines 0 comments Download
M windows/syscall.go View 1 2 chunks +2 lines, -18 lines 0 comments Download
R windows/zerrors_windows_386.go View 1 chunk +0 lines, -5 lines 0 comments Download
R windows/zerrors_windows_amd64.go View 1 chunk +0 lines, -5 lines 0 comments Download
M windows/zsyscall_windows_386.go View 14 chunks +14 lines, -14 lines 0 comments Download
M windows/zsyscall_windows_amd64.go View 14 chunks +14 lines, -14 lines 0 comments Download
M windows/ztypes_windows.go View 1 chunk +21 lines, -21 lines 0 comments Download

Messages

Total messages: 6
r
Hello rsc (cc: golang-codereviews@googlegroups.com, alex.brainman@gmail.com), I'd like you to review this change to https://code.google.com/p/go.sys
10 years, 6 months ago (2014-08-14 16:50:28 UTC) #1
rsc
LGTM
10 years, 6 months ago (2014-08-14 17:16:57 UTC) #2
r
*** Submitted as https://code.google.com/p/go/source/detail?r=7e8f794ac00a&repo=sys *** go.sys/windows: use syscall.Errno for windows errors If we use a ...
10 years, 6 months ago (2014-08-14 17:28:23 UTC) #3
brainman
LGTM but the build is broken now: # code.google.com/p/go.sys/windows ./errors_windows.go:11: cannot use ERROR_FILE_NOT_FOUND as type ...
10 years, 6 months ago (2014-08-14 23:56:57 UTC) #4
r
Sure, thanks. On Thu, Aug 14, 2014 at 4:56 PM, <alex.brainman@gmail.com> wrote: > LGTM > ...
10 years, 6 months ago (2014-08-14 23:57:55 UTC) #5
brainman
10 years, 6 months ago (2014-08-15 01:08:55 UTC) #6
Message was sent while issue was closed.
https://codereview.appspot.com/128290044/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b