Issue 12250043: code review 12250043: runtime: use gcpc/gcsp during traceback of goroutines i...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12250043: code review 12250043: runtime: use gcpc/gcsp during traceback of goroutines i... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by dvyukov

Modified:
11 years, 1 month ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

runtime: use gcpc/gcsp during traceback of goroutines in syscalls gcpc/gcsp are used by GC in similar situation. gcpc/gcsp are also more stable than gp->sched, because gp->sched is mutated by entersyscall/exitsyscall in morestack and mcall. So it has higher chances of being inconsistent. Also, rename gcpc/gcsp to syscallpc/syscallsp.

Patch Set 1 #

Patch Set 2 : diff -r b5442e956dd0 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r b5442e956dd0 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 6423f26d0193 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 6423f26d0193 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 6423f26d0193 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r 6423f26d0193 https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r 6423f26d0193 https://go.googlecode.com/hg/ #

Patch Set 9 : diff -r 6423f26d0193 https://go.googlecode.com/hg/ #

Patch Set 10 : diff -r 01d672e76b57 https://go.googlecode.com/hg/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -33 lines)			Patch
M	src/pkg/runtime/mgc0.c	View	1 2 3	1 chunk	+5 lines, -5 lines	0 comments	Download
M	src/pkg/runtime/proc.c	View	1 2 3 4 5 6 7	5 chunks	+19 lines, -20 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1 2 3	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/traceback_arm.c	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/traceback_x86.c	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

11 years, 7 months ago (2013-08-01 12:21:03 UTC) #1

dvyukov

On 2013/08/02 16:46:04, rsc wrote: > Please rename them to syscallpc and syscallsp. Done I've ...

11 years, 7 months ago (2013-08-04 12:46:52 UTC) #3

dvyukov

11 years, 7 months ago (2013-08-05 18:56:17 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=e911f94c4902 ***

runtime: use gcpc/gcsp during traceback of goroutines in syscalls
gcpc/gcsp are used by GC in similar situation.
gcpc/gcsp are also more stable than gp->sched,
because gp->sched is mutated by entersyscall/exitsyscall
in morestack and mcall. So it has higher chances of being inconsistent.
Also, rename gcpc/gcsp to syscallpc/syscallsp.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/12250043

Expand All Messages | Collapse All Messages