Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 12248043: code review 12248043: runtime: print "created by" for running goroutines in t... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by dvyukov
Modified:
11 years, 7 months ago
Reviewers:
rsc
CC:
golang-dev, r, rsc
Visibility:
Public.

Description

runtime: print "created by" for running goroutines in traceback This allows to at least determine goroutine "identity". Now it looks like: goroutine 12 [running]: goroutine running on other thread; stack unavailable created by testing.RunTests src/pkg/testing/testing.go:440 +0x88e

Patch Set 1 #

Patch Set 2 : diff -r b5442e956dd0 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r b5442e956dd0 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 6f0b4e0f38f8 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 6f0b4e0f38f8 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 6f0b4e0f38f8 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M src/pkg/runtime/proc.c View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/runtime/traceback_arm.c View 1 2 3 4 2 chunks +7 lines, -6 lines 0 comments Download
M src/pkg/runtime/traceback_x86.c View 1 2 3 4 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 7
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
11 years, 7 months ago (2013-08-01 12:08:02 UTC) #1
r
in CL desc, s/Not/Now/
11 years, 7 months ago (2013-08-01 13:19:51 UTC) #2
dvyukov
On 2013/08/01 13:19:51, r wrote: > in CL desc, s/Not/Now/ Done
11 years, 7 months ago (2013-08-01 13:25:30 UTC) #3
rsc
Please move printcreatedby back into the traceback files. It's for traceback and I'd like to ...
11 years, 7 months ago (2013-08-01 14:49:25 UTC) #4
dvyukov
On 2013/08/01 14:49:25, rsc wrote: > Please move printcreatedby back into the traceback files. It's ...
11 years, 7 months ago (2013-08-01 14:55:15 UTC) #5
rsc
LGTM
11 years, 7 months ago (2013-08-01 15:25:31 UTC) #6
dvyukov
11 years, 7 months ago (2013-08-01 15:30:14 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=8392e1e69138 ***

runtime: print "created by" for running goroutines in traceback
This allows to at least determine goroutine "identity".
Now it looks like:
goroutine 12 [running]:
        goroutine running on other thread; stack unavailable
created by testing.RunTests
        src/pkg/testing/testing.go:440 +0x88e

R=golang-dev, r, rsc
CC=golang-dev
https://codereview.appspot.com/12248043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b