Issue 12227043: code review 12227043: runtime: mark arm _lsvh nosplit (may fix arm build)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12227043: code review 12227043: runtime: mark arm _lsvh nosplit (may fix arm build) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by rsc

Modified:
11 years, 8 months ago

Reviewers:
remyoudompheng, dvyukov

CC:
golang-dev

Visibility:
Public.

runtime: mark arm _lsvh nosplit (may fix arm build) Mark the 386 one too for consistency, although most of that code is no longer used.

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/pkg/runtime/vlrt_386.c	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/pkg/runtime/vlrt_arm.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4

rsc

Hello dvyukov (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 8 months ago (2013-08-01 04:23:27 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=c632dcca98ca *** runtime: mark arm _lsvh nosplit (may fix arm build) Mark ...

11 years, 8 months ago (2013-08-01 04:23:34 UTC) #2

remyoudompheng

LGTM netbsd/arm wants _lshv to not use any stack for local variables, see https://codereview.appspot.com/11963044

11 years, 8 months ago (2013-08-01 04:31:57 UTC) #3

Message was sent while issue was closed.

LGTM