code review 12225043: build: remove builder from test suite (fix build)

build: remove builder from test suite (fix build)

[adg, 2013-08-01 03:42:22]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-08-01 03:45:06]

LGTM. Sorry for not catching that earlier. 

On 01/08/2013, at 13:42, adg@golang.org wrote:

> Reviewers: golang-dev1,
> 
> Message:
> Hello golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> https://code.google.com/p/go
> 
> 
> Description:
> build: remove builder from test suite (fix build)
> 
> Please review this at https://codereview.appspot.com/12225043/
> 
> Affected files:
>  M src/run.bash
>  M src/run.bat
>  M src/run.rc
> 
> 
> Index: src/run.bash
> ===================================================================
> --- a/src/run.bash
> +++ b/src/run.bash
> @@ -156,8 +156,8 @@
> ) || exit $?
> 
> echo
> -echo '#' ../misc/dashboard/builder ../misc/goplay
> -go build ../misc/dashboard/builder ../misc/goplay
> +echo '#' ../misc/goplay
> +go build ../misc/goplay
> 
> [ "$GOARCH" == arm ] ||
> (xcd ../test/bench/shootout
> Index: src/run.bat
> ===================================================================
> --- a/src/run.bat
> +++ b/src/run.bat
> @@ -61,8 +61,8 @@
> echo.
> :norace
> 
> -echo # ..\misc\dashboard\builder ..\misc\goplay
> -go build ..\misc\dashboard\builder ..\misc\goplay
> +echo # ..\misc\goplay
> +go build ..\misc\goplay
> if errorlevel 1 goto fail
> echo.
> 
> Index: src/run.rc
> ===================================================================
> --- a/src/run.rc
> +++ b/src/run.rc
> @@ -47,8 +47,8 @@
> }
> 
> echo
> -echo '#' ../misc/dashboard/builder ../misc/goplay
> -go build ../misc/dashboard/builder ../misc/gplay
> +echo '#' ../misc/goplay
> +go build ../misc/gplay
> 
> echo
> echo '#' ../test/bench/go1
> 
> 
> -- 
> 
> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
> 
> 

[dsymonds, 2013-08-01 03:45:34]

LGTM

[adg, 2013-08-01 03:49:09]

*** Submitted as https://code.google.com/p/go/source/detail?r=1c2053db3e0a ***

build: remove builder from test suite (fix build)

R=golang-dev, dave, dsymonds
CC=golang-dev
https://codereview.appspot.com/12225043