code review 122250043: runtime: mark functions as static where possible

runtime: mark functions as static where possible

Update issue 8092

[mdempsky, 2014-08-08 00:06:15]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[minux, 2014-08-08 00:08:03]

R=khr

[dvyukov, 2014-08-08 08:33:07]

LGTM

[dvyukov, 2014-08-08 08:50:54]

change description to:

Update issue 8092

that's magic phrase that will update the issue
don't add dot at the end

[mdempsky, 2014-08-08 15:36:48]

On 2014/08/08 08:50:54, dvyukov wrote:
> change description to:
> 
> Update issue 8092
> 
> that's magic phrase that will update the issue
> don't add dot at the end

Done.

[dvyukov, 2014-08-08 16:15:57]

*** Submitted as https://code.google.com/p/go/source/detail?r=45405d4bbe4b ***

runtime: mark functions as static where possible

Update issue 8092

LGTM=dvyukov
R=golang-codereviews, minux, dvyukov
CC=golang-codereviews
https://codereview.appspot.com/122250043

Committer: Dmitriy Vyukov <dvyukov@google.com>

[gobot, 2014-08-08 17:18:02]

This CL appears to have broken the freebsd-amd64-race builder.
See http://build.golang.org/log/14176446712894fd35fe615b7f0df63aaa870f44

[mdempsky, 2014-08-08 17:22:24]

Doesn't seem to be a flake since it failed twice in a row.  Could be
related to the change to cpuprof.goc.  Not sure why it only affects FreeBSD
and only under -race though.


On Fri, Aug 8, 2014 at 10:18 AM, <gobot@golang.org> wrote:

> This CL appears to have broken the freebsd-amd64-race builder.
> See http://build.golang.org/log/14176446712894fd35fe615b7f0df63aaa870f44
>
> https://codereview.appspot.com/122250043/
>

[dvyukov, 2014-08-08 17:26:54]

these are flakes, freebsd-race episodically fails with this error

On Fri, Aug 8, 2014 at 9:22 PM, Matthew Dempsky <mdempsky@google.com> wrote:
> Doesn't seem to be a flake since it failed twice in a row.  Could be related
> to the change to cpuprof.goc.  Not sure why it only affects FreeBSD and only
> under -race though.
>
>
> On Fri, Aug 8, 2014 at 10:18 AM, <gobot@golang.org> wrote:
>>
>> This CL appears to have broken the freebsd-amd64-race builder.
>> See http://build.golang.org/log/14176446712894fd35fe615b7f0df63aaa870f44
>>
>> https://codereview.appspot.com/122250043/
>
>

[mdempsky, 2014-08-08 17:27:53]

On Fri, Aug 8, 2014 at 10:26 AM, Dmitry Vyukov <dvyukov@google.com> wrote:

> these are flakes, freebsd-race episodically fails with this error
>

Ah, good to know.  Thanks!