Issue 12217043: code review 12217043: undo CL 11967047 / d44f1df51f4d

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12217043: code review 12217043: undo CL 11967047 / d44f1df51f4d (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by francesc

Modified:
10 years, 9 months ago

Reviewers:
adg

CC:
adg, r, golang-dev

Visibility:
Public.

Description

undo CL 11967047 / d44f1df51f4d rethinking about this ««« original CL description go.talks: add support for mouse wheel interaction on the slides. R=adg CC=golang-dev https://codereview.appspot.com/11967047 »»»

Patch Set 1 #

Patch Set 2 : diff -r d44f1df51f4d https://code.google.com/p/go.talks #

Patch Set 3 : diff -r d44f1df51f4d https://code.google.com/p/go.talks #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -12 lines)			Patch
	M	present/static/slides.js	View	1	2 chunks	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

francesc

Hello adg@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks

10 years, 9 months ago (2013-08-01 01:39:37 UTC) #1

francesc

10 years, 9 months ago (2013-08-01 01:44:31 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=7ac72015044b&repo=talks ***

undo CL 11967047 / d44f1df51f4d

rethinking about this

««« original CL description
go.talks: add support for mouse wheel interaction on the slides.

R=adg
CC=golang-dev
https://codereview.appspot.com/11967047
»»»

R=adg, r
CC=golang-dev
https://codereview.appspot.com/12217043

Expand All Messages | Collapse All Messages