Issue 12214044: code review 12214044: strings: add IndexByte, for consistency with bytes package

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12214044: code review 12214044: strings: add IndexByte, for consistency with bytes package (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by bradfitz

Modified:
11 years, 7 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

strings: add IndexByte, for consistency with bytes package I always forget which package has it.

Patch Set 1 #

Patch Set 2 : diff -r ae2811a38d8b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ae2811a38d8b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ae2811a38d8b https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r ed08d206a05c https://go.googlecode.com/hg/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
	M	src/pkg/strings/strings.go	View	1 2 3	2 chunks	+11 lines, -8 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 7 months ago (2013-08-01 17:52:01 UTC) #1

rsc

strings doesn't have IndexByte because people can write strings.Index(s, "x"); bytes.Index(s, []byte{'x'}) is clunkier and ...

11 years, 7 months ago (2013-08-01 17:58:05 UTC) #2

bradfitz

Unless the caller only has a byte. On Thu, Aug 1, 2013 at 10:58 AM, ...

11 years, 7 months ago (2013-08-01 18:07:01 UTC) #3

bradfitz

11 years, 7 months ago (2013-08-01 18:17:32 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=5de8a073bb1c ***

strings: add IndexByte, for consistency with bytes package

I always forget which package has it.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/12214044

Expand All Messages | Collapse All Messages