Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2950)

Issue 12214043: code review 12214043: cmd/go: install go.tools/cmd/godoc to $GOROOT/bin/godoc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by adg
Modified:
11 years, 8 months ago
Reviewers:
rsc
CC:
golang-dev, r, rsc
Visibility:
Public.

Description

cmd/go: install go.tools/cmd/godoc to $GOROOT/bin/godoc Also suggest "go get" if godoc not found when running "go doc".

Patch Set 1 #

Patch Set 2 : diff -r 96e7c213f1e5 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -13 lines) Patch
M src/cmd/go/fmt.go View 2 chunks +7 lines, -0 lines 0 comments Download
M src/cmd/go/pkg.go View 2 chunks +25 lines, -13 lines 0 comments Download

Messages

Total messages: 5
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 8 months ago (2013-08-01 01:06:31 UTC) #1
r
looks bug but wait for rsc.
11 years, 8 months ago (2013-08-01 01:13:45 UTC) #2
r
s/bug/good/ and get me a coffee
11 years, 8 months ago (2013-08-01 01:14:21 UTC) #3
rsc
LGTM
11 years, 8 months ago (2013-08-01 01:16:15 UTC) #4
adg
11 years, 8 months ago (2013-08-01 01:17:49 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=a2e6a2fddcf5 ***

cmd/go: install go.tools/cmd/godoc to $GOROOT/bin/godoc

Also suggest "go get" if godoc not found when running "go doc".

R=golang-dev, r, rsc
CC=golang-dev
https://codereview.appspot.com/12214043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b