Issue 121910043: code review 121910043: runtime: fix cmallocgc's C prototype

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 121910043: code review 121910043: runtime: fix cmallocgc's C prototype (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by mdempsky

Modified:
10 years, 7 months ago

Reviewers:
gobot, khr, dave, khr1

CC:
khr, khr1, golang-codereviews

Visibility:
Public.

Patch Set 2 : diff -r ad109b6a9417 https://code.google.com/p/go #

Patch Set 3 : diff -r ad109b6a9417 https://code.google.com/p/go #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/runtime/malloc.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

mdempsky

Hello khr@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 7 months ago (2014-07-30 17:03:54 UTC) #1

khr1

LGTM. On Wed, Jul 30, 2014 at 10:03 AM, <mdempsky@google.com> wrote: > Reviewers: khr, > ...

10 years, 7 months ago (2014-07-30 17:11:22 UTC) #2

khr

*** Submitted as https://code.google.com/p/go/source/detail?r=ec4b62f06a49 *** runtime: fix cmallocgc's C prototype LGTM=khr R=khr CC=golang-codereviews https://codereview.appspot.com/121910043 Committer: ...

10 years, 7 months ago (2014-07-31 00:08:39 UTC) #3

gobot

This CL appears to have broken the freebsd-amd64-race builder. See http://build.golang.org/log/27038f30f22e1aa4cad6f68fe78f9cbc12b4a7cd

10 years, 7 months ago (2014-07-31 00:17:55 UTC) #4

dave_cheney.net

10 years, 7 months ago (2014-07-31 00:19:19 UTC) #5

Nope,

ok  	runtime/debug	1.131s
--- FAIL: TestCPUProfileMultithreaded (16.60s)
	pprof_test.go:136: crc32.ChecksumIEEE: 0
	pprof_test.go:136: crc32.Update: 2
	pprof_test.go:150: crc32.ChecksumIEEE has 0 samples out of 2, want at
least 1, ideally 1
FAIL
FAIL	runtime/pprof	39.280s
ok  	runtime/race	23.346s


Although this test does break often.



On Thu, Jul 31, 2014 at 10:17 AM, <gobot@golang.org> wrote:

> This CL appears to have broken the freebsd-amd64-race builder.
> See http://build.golang.org/log/27038f30f22e1aa4cad6f68fe78f9cbc12b4a7cd
>
>
> https://codereview.appspot.com/121910043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

Expand All Messages | Collapse All Messages