LGTM https://codereview.appspot.com/12183044/diff/18001/src/pkg/runtime/pprof/pprof_test.go File src/pkg/runtime/pprof/pprof_test.go (right): https://codereview.appspot.com/12183044/diff/18001/src/pkg/runtime/pprof/pprof_test.go#newcode149 src/pkg/runtime/pprof/pprof_test.go:149: // This makes fork slower. does this reliably ...
10 years, 7 months ago
(2013-08-12 22:58:09 UTC)
#3
On 2013/08/13 09:01:42, dvyukov wrote: > *** Submitted as https://code.google.com/p/go/source/detail?r=9eb1dd061b1f *** > > syscall: disable ...
10 years, 7 months ago
(2013-08-21 02:32:52 UTC)
#6
Message was sent while issue was closed.
On 2013/08/13 09:01:42, dvyukov wrote:
> *** Submitted as https://code.google.com/p/go/source/detail?r=9eb1dd061b1f ***
>
> syscall: disable cpu profiling around fork
> Fixes issue 5517.
> Fixes issue 5659.
>
> R=golang-dev, bradfitz
> CC=golang-dev
> https://codereview.appspot.com/12183044
Dmitry, did adding an extra call to runtime_{Before,After}fork violate the
contract at the top of the exec function ? Those functions aren't #pragma 7 so
could cause a stack split and an allocation. Is this a real concern, or am I
barking at shadows ?
On 2013/08/21 02:32:52, dfc wrote: > On 2013/08/13 09:01:42, dvyukov wrote: > > *** Submitted ...
10 years, 7 months ago
(2013-08-21 09:45:19 UTC)
#7
Message was sent while issue was closed.
On 2013/08/21 02:32:52, dfc wrote:
> On 2013/08/13 09:01:42, dvyukov wrote:
> > *** Submitted as https://code.google.com/p/go/source/detail?r=9eb1dd061b1f
***
> >
> > syscall: disable cpu profiling around fork
> > Fixes issue 5517.
> > Fixes issue 5659.
> >
> > R=golang-dev, bradfitz
> > CC=golang-dev
> > https://codereview.appspot.com/12183044
>
> Dmitry, did adding an extra call to runtime_{Before,After}fork violate the
> contract at the top of the exec function ? Those functions aren't #pragma 7 so
> could cause a stack split and an allocation. Is this a real concern, or am I
> barking at shadows ?
The special concerns are only applicable to child process (because it can be
forked off with runtime mutex locked or something), runtime_{Before,After}fork
must be called only in parent (which is a completely normal Go process with
normal rules).
I understand, thank you for addressing my concerns. On Wed, Aug 21, 2013 at 7:45 ...
10 years, 7 months ago
(2013-08-21 10:03:49 UTC)
#8
I understand, thank you for addressing my concerns.
On Wed, Aug 21, 2013 at 7:45 PM, <dvyukov@google.com> wrote:
> On 2013/08/21 02:32:52, dfc wrote:
>>
>> On 2013/08/13 09:01:42, dvyukov wrote:
>> > *** Submitted as
>
> https://code.google.com/p/go/source/detail?r=9eb1dd061b1f ***
>>
>> >
>> > syscall: disable cpu profiling around fork
>> > Fixes issue 5517.
>> > Fixes issue 5659.
>> >
>> > R=golang-dev, bradfitz
>> > CC=golang-dev
>> > https://codereview.appspot.com/12183044
>
>
>> Dmitry, did adding an extra call to runtime_{Before,After}fork violate
>
> the
>>
>> contract at the top of the exec function ? Those functions aren't
>
> #pragma 7 so
>>
>> could cause a stack split and an allocation. Is this a real concern,
>
> or am I
>>
>> barking at shadows ?
>
>
> The special concerns are only applicable to child process (because it
> can be forked off with runtime mutex locked or something),
> runtime_{Before,After}fork must be called only in parent (which is a
> completely normal Go process with normal rules).
>
>
>
> https://codereview.appspot.com/12183044/
Issue 12183044: code review 12183044: syscall: disable cpu profiling around fork
(Closed)
Created 10 years, 8 months ago by dvyukov
Modified 10 years, 7 months ago
Reviewers: dfc
Base URL:
Comments: 4