Issue 12182044: code review 12182044: runtime: save 8 stack bytes in timediv on arm.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12182044: code review 12182044: runtime: save 8 stack bytes in timediv on arm. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by remyoudompheng

Modified:
11 years, 8 months ago

Reviewers:
dave, dvyukov, bradfitz

CC:
golang-dev, dvyukov, bradfitz

Visibility:
Public.

Description

runtime: save 8 stack bytes in timediv on arm. Operations on int64 are very stack consuming with 5c. Fixes netbsd/arm build. Before: TEXT runtime.timediv+0(SB),7,$52-16 After: TEXT runtime.timediv+0(SB),7,$44-16 The stack usage is unchanged on 386: TEXT runtime.timediv+0(SB),7,$8-16

Patch Set 1 #

Patch Set 2 : diff -r 38097c493d8a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 38097c493d8a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 43f967f62292 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 43f967f62292 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 43f967f62292 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r 43f967f62292 https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r ae2811a38d8b https://go.googlecode.com/hg/ #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	src/pkg/runtime/runtime.c	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 8 months ago (2013-07-31 21:19:55 UTC) #1

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 8 months ago (2013-07-31 21:22:09 UTC) #2

remyoudompheng

*** Submitted as https://code.google.com/p/go/source/detail?r=2627f7ba15d2 *** runtime: save 8 stack bytes in timediv on arm. Operations ...

11 years, 8 months ago (2013-07-31 21:37:29 UTC) #5

dave_cheney.net

11 years, 8 months ago (2013-08-01 01:16:39 UTC) #6

Message was sent while issue was closed.

On 2013/07/31 21:37:29, remyoudompheng wrote:
> *** Submitted as https://code.google.com/p/go/source/detail?r=2627f7ba15d2 ***
> 
> runtime: save 8 stack bytes in timediv on arm.
> 
> Operations on int64 are very stack consuming with 5c.
> Fixes netbsd/arm build.
> 
> Before: TEXT    runtime.timediv+0(SB),7,$52-16
> After:  TEXT    runtime.timediv+0(SB),7,$44-16
> 
> The stack usage is unchanged on 386:
>         TEXT    runtime.timediv+0(SB),7,$8-16
> 
> R=golang-dev, dvyukov, bradfitz
> CC=golang-dev
> https://codereview.appspot.com/12182044

Strangely this made things worse, not better.

Expand All Messages | Collapse All Messages