Issue 12182043: code review 12182043: runtime: better debug output for inconsistent Note

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12182043: code review 12182043: runtime: better debug output for inconsistent Note (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by dvyukov

Modified:
10 years, 9 months ago

Reviewers:
bradfitz

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

runtime: better debug output for inconsistent Note Update issue 5139. Double wakeup on Note was reported several times, but no reliable reproducer. There also was a strange report about weird value of epoll fd. Maybe it's corruption of global data...

Patch Set 1 #

Patch Set 2 : diff -r aaec807a07a1 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r aaec807a07a1 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r aaec807a07a1 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/pkg/runtime/lock_futex.c	View	1	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

10 years, 9 months ago (2013-07-31 17:11:11 UTC) #1

dvyukov

10 years, 9 months ago (2013-07-31 18:04:08 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=5333e97ad270 ***

runtime: better debug output for inconsistent Note
Update issue 5139.
Double wakeup on Note was reported several times,
but no reliable reproducer.
There also was a strange report about weird value of epoll fd.
Maybe it's corruption of global data...

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12182043

Expand All Messages | Collapse All Messages