Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2892)

Issue 12176043: code review 12176043: runtime: do not park sysmon thread if any goroutines ar... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by dvyukov
Modified:
11 years, 8 months ago
Reviewers:
rsc
CC:
rsc, golang-dev
Visibility:
Public.

Description

runtime: do not park sysmon thread if any goroutines are running Sysmon thread parks if no goroutines are running (runtime.sched.npidle == runtime.gomaxprocs). Currently it's unparked when a goroutine enters syscall, it was enough to retake P's from blocking syscalls. But it's not enough for reliable goroutine preemption. We need to ensure that sysmon runs if any goroutines are running.

Patch Set 1 #

Patch Set 2 : diff -r 02a12c00b934 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 02a12c00b934 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 02a12c00b934 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/pkg/runtime/proc.c View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4
dvyukov
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
11 years, 8 months ago (2013-07-31 16:08:25 UTC) #1
dvyukov
This is the same as https://codereview.appspot.com/12167043/ but w/o unrelated changes this time.
11 years, 8 months ago (2013-07-31 16:08:50 UTC) #2
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=aaec807a07a1 *** runtime: do not park sysmon thread if any goroutines are ...
11 years, 8 months ago (2013-07-31 16:09:14 UTC) #3
rsc
11 years, 8 months ago (2013-08-02 15:54:44 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b