Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1094)

Issue 12171044: code review 12171044: undo CL 12167043 / 475e11851fc1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by dvyukov
Modified:
11 years, 8 months ago
Reviewers:
rsc
CC:
rsc, golang-dev
Visibility:
Public.

Description

undo CL 12167043 / 475e11851fc1 Submitted with some unrelated changes that were not intended to go in. ««« original CL description runtime: do not park sysmon thread if any goroutines are running Sysmon thread parks if no goroutines are running (runtime.sched.npidle == runtime.gomaxprocs). Currently it's unparked when a goroutine enters syscall, it was enough to retake P's from blocking syscalls. But it's not enough for reliable goroutine preemption. We need to ensure that sysmon runs if any goroutines are running. R=golang-dev, rsc CC=golang-dev https://codereview.appspot.com/12167043 »»»

Patch Set 1 #

Patch Set 2 : diff -r a68db2ccc3cb https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -26 lines) Patch
M src/pkg/runtime/proc.c View 1 3 chunks +4 lines, -26 lines 0 comments Download

Messages

Total messages: 3
dvyukov
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
11 years, 8 months ago (2013-07-31 16:03:03 UTC) #1
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=02a12c00b934 *** undo CL 12167043 / 475e11851fc1 Submitted with some unrelated changes ...
11 years, 8 months ago (2013-07-31 16:03:12 UTC) #2
rsc
11 years, 8 months ago (2013-08-02 15:54:34 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b