Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2739)

Issue 12170046: code review 12170046: undo CL 11884043 / bfd5ed8236d5 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by gri
Modified:
11 years, 8 months ago
Reviewers:
r
CC:
golang-dev
Visibility:
Public.

Description

undo CL 11884043 / bfd5ed8236d5 CL submitted prematurely by mistake. ««« original CL description spec: clarify index and selector expressions 1) Explain a[i] and a[i:j] where a is of type *A as shortcut for (*a)[i] and (*a)[i:j], respectively. 2) Together with 1), because len() of nil slices is well defined, there's no need to special case nil operands anymore. 3) The result of indexing or slicing a constant string is always a non-constant byte or string value. 4) The result of slicing an untyped string is a value of type string. 5) If the operand of a valid slice a[i:j] is nil (i, j must be 0 for it to be valid - this already follows from the in-range rules), the result is a nil slice. Fixes issue 4913. Fixes issue 5951. R=rsc, r, iant, ken CC=golang-dev https://codereview.appspot.com/11884043 »»»

Patch Set 1 #

Patch Set 2 : diff -r bfd5ed8236d5 https://code.google.com/p/go #

Patch Set 3 : diff -r bfd5ed8236d5 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -44 lines) Patch
M doc/go_spec.html View 1 8 chunks +31 lines, -44 lines 0 comments Download

Messages

Total messages: 3
gri
Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 8 months ago (2013-07-31 21:09:46 UTC) #1
gri
*** Submitted as https://code.google.com/p/go/source/detail?r=63235d688030 *** undo CL 11884043 / bfd5ed8236d5 CL submitted prematurely by mistake. ...
11 years, 8 months ago (2013-07-31 21:10:48 UTC) #2
r
11 years, 8 months ago (2013-07-31 21:12:40 UTC) #3
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b