Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(304)

Issue 121520043: code review 121520043: go.sys: update package names (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by r
Modified:
10 years, 7 months ago
Reviewers:
rsc
CC:
golang-codereviews, rsc
Visibility:
Public.

Description

go.sys: update package names Semi-automatic migration from package syscall to package {plan9,windows,unix}. No builds attempted yet, but this gets a lot of noise behind us so subsequent CLs will be more concise and easier to follow. Subsequent CLs will have semantic content.

Patch Set 1 #

Patch Set 2 : diff -r ad63a19ca444543ec83ec030d1200b0510f3f192 https://code.google.com/p/go.sys #

Patch Set 3 : diff -r ad63a19ca444543ec83ec030d1200b0510f3f192 https://code.google.com/p/go.sys #

Unified diffs Side-by-side diffs Delta from patch set Stats (+372 lines, -825 lines) Patch
M plan9/asm_plan9_386.s View 2 chunks +2 lines, -2 lines 0 comments Download
M plan9/asm_plan9_amd64.s View 2 chunks +2 lines, -2 lines 0 comments Download
M plan9/dir_plan9.go View 3 chunks +3 lines, -3 lines 0 comments Download
M plan9/env_plan9.go View 1 chunk +1 line, -1 line 0 comments Download
M plan9/exec_plan9.go View 1 chunk +1 line, -1 line 0 comments Download
M plan9/mkall.sh View 3 chunks +2 lines, -127 lines 0 comments Download
M plan9/mkerrors.sh View 2 chunks +1 line, -188 lines 0 comments Download
M plan9/mksyscall.pl View 2 chunks +2 lines, -2 lines 0 comments Download
M plan9/mksysnum_plan9.sh View 1 chunk +1 line, -1 line 0 comments Download
M plan9/race.go View 1 chunk +1 line, -1 line 0 comments Download
M plan9/race0.go View 1 chunk +1 line, -1 line 0 comments Download
M plan9/str.go View 1 chunk +1 line, -1 line 0 comments Download
M plan9/syscall.go View 1 chunk +7 lines, -8 lines 0 comments Download
M plan9/syscall_plan9.go View 1 chunk +1 line, -1 line 0 comments Download
M plan9/syscall_test.go View 1 chunk +5 lines, -4 lines 0 comments Download
M plan9/zerrors_plan9_386.go View 1 chunk +1 line, -1 line 0 comments Download
M plan9/zerrors_plan9_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M plan9/zsyscall_plan9_386.go View 1 chunk +1 line, -1 line 0 comments Download
M plan9/zsyscall_plan9_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M plan9/zsysnum_plan9_386.go View 1 chunk +1 line, -1 line 0 comments Download
M plan9/zsysnum_plan9_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M plan9/ztypes_plan9_386.go View 1 chunk +1 line, -1 line 0 comments Download
M plan9/ztypes_plan9_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/asm_nacl_386.s View 2 chunks +3 lines, -3 lines 0 comments Download
M unix/asm_nacl_amd64p32.s View 2 chunks +3 lines, -3 lines 0 comments Download
M unix/asm_nacl_arm.s View 2 chunks +3 lines, -3 lines 0 comments Download
M unix/asm_netbsd_386.s View 1 chunk +1 line, -1 line 0 comments Download
M unix/asm_netbsd_amd64.s View 1 chunk +1 line, -1 line 0 comments Download
M unix/asm_netbsd_arm.s View 1 chunk +1 line, -1 line 0 comments Download
M unix/asm_openbsd_386.s View 1 chunk +1 line, -1 line 0 comments Download
M unix/asm_openbsd_amd64.s View 1 chunk +1 line, -1 line 0 comments Download
M unix/asm_solaris_amd64.s View 1 chunk +1 line, -1 line 0 comments Download
M unix/bpf_bsd.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/creds_test.go View 1 5 chunks +12 lines, -12 lines 0 comments Download
M unix/env_unix.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/exec_bsd.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/exec_linux.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/exec_solaris.go View 2 chunks +2 lines, -2 lines 0 comments Download
M unix/exec_unix.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/fd_nacl.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/flock.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/flock_linux_32bit.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/fs_nacl.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/lsf_linux.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/mkall.sh View 3 chunks +1 line, -17 lines 0 comments Download
M unix/mksyscall.pl View 1 chunk +1 line, -1 line 0 comments Download
M unix/mksyscall_solaris.pl View 1 chunk +1 line, -1 line 0 comments Download
M unix/mksysctl_openbsd.pl View 1 chunk +1 line, -1 line 0 comments Download
M unix/mksysnum_darwin.pl View 1 chunk +1 line, -1 line 0 comments Download
M unix/mksysnum_dragonfly.pl View 1 chunk +1 line, -1 line 0 comments Download
M unix/mksysnum_freebsd.pl View 1 chunk +1 line, -1 line 0 comments Download
M unix/mksysnum_linux.pl View 1 chunk +1 line, -1 line 0 comments Download
M unix/mksysnum_netbsd.pl View 1 chunk +1 line, -1 line 0 comments Download
M unix/mksysnum_openbsd.pl View 1 chunk +1 line, -1 line 0 comments Download
M unix/mmap_unix_test.go View 1 1 chunk +4 lines, -4 lines 0 comments Download
M unix/net_nacl.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/netlink_linux.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/race.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/race0.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/route_bsd.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/route_darwin.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/route_dragonfly.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/route_freebsd.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/route_freebsd_32bit.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/route_freebsd_64bit.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/route_netbsd.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/route_openbsd.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/so_solaris.go View 1 4 chunks +9 lines, -9 lines 0 comments Download
M unix/sockcmsg_linux.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/sockcmsg_unix.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/srpc_nacl.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/str.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall.go View 3 chunks +9 lines, -9 lines 0 comments Download
M unix/syscall_bsd.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_bsd_test.go View 1 1 chunk +6 lines, -6 lines 0 comments Download
M unix/syscall_darwin.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_darwin_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_darwin_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_dragonfly.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_dragonfly_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_dragonfly_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_freebsd.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_freebsd_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_freebsd_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_freebsd_arm.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_linux.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_linux_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_linux_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_linux_arm.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_nacl.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_nacl_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_nacl_amd64p32.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_nacl_arm.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_netbsd.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_netbsd_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_netbsd_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_netbsd_arm.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_no_getwd.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_openbsd.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_openbsd_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_openbsd_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_solaris.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_solaris_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_test.go View 1 1 chunk +4 lines, -4 lines 0 comments Download
M unix/syscall_unix.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/syscall_unix_test.go View 1 14 chunks +38 lines, -38 lines 0 comments Download
M unix/tables_nacl.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/time_nacl_386.s View 1 chunk +1 line, -1 line 0 comments Download
M unix/time_nacl_amd64p32.s View 1 chunk +1 line, -1 line 0 comments Download
M unix/time_nacl_arm.s View 1 chunk +1 line, -1 line 0 comments Download
M unix/types_darwin.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/types_dragonfly.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/types_freebsd.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/types_linux.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/types_netbsd.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/types_openbsd.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/types_solaris.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/unzip_nacl.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zerrors_darwin_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zerrors_darwin_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zerrors_dragonfly_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zerrors_dragonfly_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zerrors_freebsd_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zerrors_freebsd_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zerrors_freebsd_arm.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zerrors_linux_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zerrors_linux_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zerrors_linux_arm.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zerrors_netbsd_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zerrors_netbsd_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zerrors_netbsd_arm.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zerrors_openbsd_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zerrors_openbsd_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zerrors_solaris_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zsyscall_darwin_386.go View 1 chunk +2 lines, -2 lines 0 comments Download
M unix/zsyscall_darwin_amd64.go View 1 chunk +2 lines, -2 lines 0 comments Download
M unix/zsyscall_dragonfly_386.go View 1 chunk +2 lines, -2 lines 0 comments Download
M unix/zsyscall_dragonfly_amd64.go View 1 chunk +2 lines, -2 lines 0 comments Download
M unix/zsyscall_freebsd_386.go View 1 chunk +2 lines, -2 lines 0 comments Download
M unix/zsyscall_freebsd_amd64.go View 1 chunk +2 lines, -2 lines 0 comments Download
M unix/zsyscall_freebsd_arm.go View 1 chunk +2 lines, -2 lines 0 comments Download
M unix/zsyscall_linux_386.go View 1 chunk +2 lines, -2 lines 0 comments Download
M unix/zsyscall_linux_amd64.go View 1 chunk +2 lines, -2 lines 0 comments Download
M unix/zsyscall_linux_arm.go View 1 chunk +2 lines, -2 lines 0 comments Download
M unix/zsyscall_nacl_386.go View 1 chunk +2 lines, -2 lines 0 comments Download
M unix/zsyscall_nacl_amd64p32.go View 1 chunk +2 lines, -2 lines 0 comments Download
M unix/zsyscall_nacl_arm.go View 1 chunk +2 lines, -2 lines 0 comments Download
M unix/zsyscall_netbsd_386.go View 1 chunk +2 lines, -2 lines 0 comments Download
M unix/zsyscall_netbsd_amd64.go View 1 chunk +2 lines, -2 lines 0 comments Download
M unix/zsyscall_netbsd_arm.go View 1 chunk +2 lines, -2 lines 0 comments Download
M unix/zsyscall_openbsd_386.go View 1 chunk +2 lines, -2 lines 0 comments Download
M unix/zsyscall_openbsd_amd64.go View 1 chunk +2 lines, -2 lines 0 comments Download
M unix/zsyscall_solaris_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zsysctl_openbsd.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zsysnum_darwin_386.go View 1 chunk +2 lines, -2 lines 0 comments Download
M unix/zsysnum_darwin_amd64.go View 1 chunk +2 lines, -2 lines 0 comments Download
M unix/zsysnum_dragonfly_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zsysnum_dragonfly_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zsysnum_freebsd_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zsysnum_freebsd_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zsysnum_freebsd_arm.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zsysnum_linux_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zsysnum_linux_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zsysnum_linux_arm.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zsysnum_netbsd_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zsysnum_netbsd_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zsysnum_netbsd_arm.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zsysnum_openbsd_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zsysnum_openbsd_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/zsysnum_solaris_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/ztypes_darwin_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/ztypes_darwin_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/ztypes_dragonfly_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/ztypes_dragonfly_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/ztypes_freebsd_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/ztypes_freebsd_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/ztypes_freebsd_arm.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/ztypes_linux_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/ztypes_linux_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/ztypes_linux_arm.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/ztypes_netbsd_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/ztypes_netbsd_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/ztypes_netbsd_arm.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/ztypes_openbsd_386.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/ztypes_openbsd_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M unix/ztypes_solaris_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M windows/asm_windows_386.s View 1 chunk +1 line, -1 line 0 comments Download
M windows/asm_windows_amd64.s View 1 chunk +1 line, -1 line 0 comments Download
M windows/dll_windows.go View 1 4 chunks +6 lines, -6 lines 0 comments Download
M windows/env_windows.go View 1 chunk +1 line, -1 line 0 comments Download
M windows/exec_windows.go View 1 chunk +1 line, -1 line 0 comments Download
M windows/mkall.sh View 3 chunks +1 line, -126 lines 0 comments Download
M windows/mksyscall.pl View 2 chunks +2 lines, -2 lines 0 comments Download
M windows/mksyscall_windows.go View 9 chunks +14 lines, -14 lines 0 comments Download
M windows/race.go View 1 chunk +1 line, -1 line 0 comments Download
M windows/race0.go View 1 chunk +1 line, -1 line 0 comments Download
M windows/security_windows.go View 1 chunk +1 line, -1 line 0 comments Download
M windows/str.go View 1 chunk +1 line, -1 line 0 comments Download
M windows/syscall.go View 2 chunks +7 lines, -7 lines 0 comments Download
M windows/syscall_test.go View 1 1 chunk +4 lines, -4 lines 0 comments Download
M windows/syscall_windows.go View 4 chunks +4 lines, -4 lines 0 comments Download
M windows/syscall_windows_386.go View 1 chunk +1 line, -1 line 0 comments Download
M windows/syscall_windows_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M windows/syscall_windows_test.go View 1 4 chunks +10 lines, -10 lines 0 comments Download
M windows/zerrors_windows.go View 1 chunk +1 line, -1 line 0 comments Download
M windows/zerrors_windows_386.go View 1 chunk +1 line, -1 line 0 comments Download
M windows/zerrors_windows_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M windows/zsyscall_windows_386.go View 1 chunk +1 line, -1 line 0 comments Download
M windows/zsyscall_windows_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M windows/zsysnum_windows_386.go View 1 chunk +1 line, -1 line 0 comments Download
M windows/zsysnum_windows_amd64.go View 1 chunk +1 line, -1 line 0 comments Download
M windows/ztypes_windows.go View 1 chunk +1 line, -1 line 0 comments Download
M windows/ztypes_windows_386.go View 1 chunk +1 line, -1 line 0 comments Download
M windows/ztypes_windows_amd64.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
r
Hello golang-codereviews@googlegroups.com (cc: rsc@golang.org), I'd like you to review this change to https://code.google.com/p/go.sys
10 years, 7 months ago (2014-08-11 22:38:58 UTC) #1
rsc
LGTM
10 years, 7 months ago (2014-08-11 22:46:32 UTC) #2
r
10 years, 7 months ago (2014-08-11 22:56:24 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=6a09d4d5dbf2&repo=sys ***

go.sys: update package names
Semi-automatic migration from package syscall to package {plan9,windows,unix}.
No builds attempted yet, but this gets a lot of noise behind us so subsequent
CLs will be more concise and easier to follow.
Subsequent CLs will have semantic content.

LGTM=rsc
R=golang-codereviews, rsc
CC=golang-codereviews
https://codereview.appspot.com/121520043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b