Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2735)

Issue 12149043: code review 12149043: doc: don't invoke go build with -o /dev/null during test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by kortschak
Modified:
11 years, 8 months ago
Reviewers:
khr1
CC:
golang-dev, khr1
Visibility:
Public.

Description

doc: don't invoke go build with -o /dev/null during test Fixes Issue 5998.

Patch Set 1 #

Patch Set 2 : diff -r cd0bae7395e8 https://code.google.com/p/go/ #

Patch Set 3 : diff -r cd0bae7395e8 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M doc/codewalk/run View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
kortschak
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 8 months ago (2013-07-31 07:23:12 UTC) #1
khr1
LGTM. On Wed, Jul 31, 2013 at 12:23 AM, <dan.kortschak@adelaide.edu.au> wrote: > Reviewers: golang-dev1, > ...
11 years, 8 months ago (2013-07-31 15:22:13 UTC) #2
r
11 years, 8 months ago (2013-08-01 01:03:19 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=96e7c213f1e5 ***

doc: don't invoke go build with -o /dev/null during test

Fixes Issue 5998.

R=golang-dev, khr
CC=golang-dev
https://codereview.appspot.com/12149043

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b