Issue 12128043: code review 12128043: runtime: fix Plan 9 build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12128043: code review 12128043: runtime: fix Plan 9 build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by 0intro

Modified:
11 years, 5 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

runtime: fix Plan 9 build The current failures were: fatal error: runtime: stack split during syscall goroutine 1 [stack split]: runtime.findnull(0x105a9080) /usr/go/src/pkg/runtime/string.goc:14 fp=0x305aefb8 runtime: unexpected return pc for runtime.errstr called from 0x80 runtime.errstr() /usr/go/src/pkg/runtime/sys_plan9_386.s:196 +0x2f fp=0x305aefc8 fatal error: runtime: stack split during syscall goroutine 2 [stack split]: runtime.nanotime(0x305bff3c) /usr/go/src/pkg/runtime/time_plan9_386.c:9 fp=0x305bff34 notetsleep(0x305bff9c, 0xf8475800, 0xd, 0x0, 0x0, ...) /usr/go/src/pkg/runtime/lock_sema.c:195 +0x87 fp=0x305bff48 runtime.notetsleepg(0x305bff9c, 0xf8475800, 0xd) /usr/go/src/pkg/runtime/lock_sema.c:266 +0xa4 fp=0x305bff68 runtime.MHeap_Scavenger() /usr/go/src/pkg/runtime/mheap.c:463 +0xc2 fp=0x305bffd0 runtime.goexit() /usr/go/src/pkg/runtime/proc.c:1332 fp=0x305bffd4 created by runtime.main /usr/go/src/pkg/runtime/proc.c:168

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/pkg/runtime/string.goc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/pkg/runtime/time_plan9_386.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

0intro

Hello golang-dev1 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 7 months ago (2013-07-30 21:21:01 UTC) #1

bradfitz

11 years, 7 months ago (2013-08-06 14:37:31 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=edb46df3ae05 ***

runtime: fix Plan 9 build

The current failures were:

fatal error: runtime: stack split during syscall
goroutine 1 [stack split]:
runtime.findnull(0x105a9080)
        /usr/go/src/pkg/runtime/string.goc:14 fp=0x305aefb8
runtime: unexpected return pc for runtime.errstr called from 0x80
runtime.errstr()
        /usr/go/src/pkg/runtime/sys_plan9_386.s:196 +0x2f fp=0x305aefc8

fatal error: runtime: stack split during syscall
goroutine 2 [stack split]:
runtime.nanotime(0x305bff3c)
        /usr/go/src/pkg/runtime/time_plan9_386.c:9 fp=0x305bff34
notetsleep(0x305bff9c, 0xf8475800, 0xd, 0x0, 0x0, ...)
        /usr/go/src/pkg/runtime/lock_sema.c:195 +0x87 fp=0x305bff48
runtime.notetsleepg(0x305bff9c, 0xf8475800, 0xd)
        /usr/go/src/pkg/runtime/lock_sema.c:266 +0xa4 fp=0x305bff68
runtime.MHeap_Scavenger()
        /usr/go/src/pkg/runtime/mheap.c:463 +0xc2 fp=0x305bffd0
runtime.goexit()
        /usr/go/src/pkg/runtime/proc.c:1332 fp=0x305bffd4
created by runtime.main
        /usr/go/src/pkg/runtime/proc.c:168

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/12128043

Committer: Brad Fitzpatrick <bradfitz@golang.org>

Expand All Messages | Collapse All Messages