code review 12117043: net/http: don't MIME sniff if handler set an empty stri...

net/http: don't MIME sniff if handler set an empty string Content-Type

Fixes issue 5953

[bradfitz, 2013-07-31 22:37:05]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[dsymonds, 2013-08-01 00:27:27]

should the output have *no* Content-Type header instead of "Content-Type:
\r\n"?

[bradfitz, 2013-08-01 00:29:17]

No.

That would happen with []string{} but not with an explicit empty string.

That's not what this bug is about.
On Jul 31, 2013 5:27 PM, "David Symonds" <dsymonds@golang.org> wrote:

> should the output have *no* Content-Type header instead of "Content-Type:
> \r\n"?
>

[dsymonds, 2013-08-01 00:30:55]

LGTM

fair enough

[bradfitz, 2013-08-01 06:38:36]

*** Submitted as https://code.google.com/p/go/source/detail?r=c8247d0380cd ***

net/http: don't MIME sniff if handler set an empty string Content-Type

Fixes issue 5953

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/12117043

[piatek, 2013-10-04 23:38:01]

https://codereview.appspot.com/12117043/diff/8001/src/pkg/net/http/server.go
File src/pkg/net/http/server.go (right):

https://codereview.appspot.com/12117043/diff/8001/src/pkg/net/http/server.go#...
src/pkg/net/http/server.go:341: return !w.cw.wroteHeader &&
w.handlerHeader.Get("Content-Type") == "" && w.written < sniffLen
I realize I'm a few months late to the game, but shouldn't the check be
duplicated here to prevent buffering for sniffing that will not occur?

[dsymonds, 2013-10-05 03:46:15]

On 2013/10/04 23:38:01, piatek wrote:
> https://codereview.appspot.com/12117043/diff/8001/src/pkg/net/http/server.go
> File src/pkg/net/http/server.go (right):
> 
>
https://codereview.appspot.com/12117043/diff/8001/src/pkg/net/http/server.go#...
> src/pkg/net/http/server.go:341: return !w.cw.wroteHeader &&
> w.handlerHeader.Get("Content-Type") == "" && w.written < sniffLen
> I realize I'm a few months late to the game, but shouldn't the check be
> duplicated here to prevent buffering for sniffing that will not occur?

Probably. Want to send a CL?