code review 121040043: go/doc: allow headings to begin with non-uppercase letters

go/doc: allow headings to begin with non-uppercase letters

ToHTML will now find headings in comments written in scripts that don't have
uppercase letters.
Fixes issue 7349.

[esk, 2014-08-01 04:36:24]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[gobot, 2014-08-03 17:20:57]

R=gri@golang.org (assigned by r@golang.org)

[volker.dobler, 2014-08-04 07:28:06]

Has this CL been tested on some (large) corpus of
Go code to make sure it doesn't produce false positives?
At least the standard library and the subrepos should
be checked IMHO.

[esk, 2014-08-04 17:04:43]

On 2014/08/04 07:28:06, volker.dobler wrote:
> Has this CL been tested on some (large) corpus of
> Go code to make sure it doesn't produce false positives?
> At least the standard library and the subrepos should
> be checked IMHO.

No, it hasn't. I'm going to test it on the standard library once I've fixed
headscan.go (see https://code.google.com/p/go/issues/detail?id=8467).

[gri, 2014-08-04 18:14:11]

What's the rationale for this change?

[ioe, 2014-08-04 21:39:05]

On Monday, August 4, 2014 8:14:11 PM UTC+2, g...@golang.org wrote:
> What's the rationale for this change?

I would guess the missing concept of uppercase/lowercase in several languages as
illustrated here: http://play.golang.org/p/5D2mHu2F7S

https://codereview.appspot.com/121040043/

[gri, 2014-08-04 21:40:49]

Fair enough. Should probably say so in the CL desc.
- gri


On Mon, Aug 4, 2014 at 2:39 PM, <nightlyone@googlemail.com> wrote:

> On Monday, August 4, 2014 8:14:11 PM UTC+2, g...@golang.org wrote:
> > What's the rationale for this change?
>
> I would guess the missing concept of uppercase/lowercase in several
> languages as illustrated here: http://play.golang.org/p/5D2mHu2F7S
>
> https://codereview.appspot.com/121040043/
>

[esk, 2014-08-05 02:46:18]

On 2014/08/04 21:40:49, gri wrote:
> Fair enough. Should probably say so in the CL desc.
> - gri
> 
> 
> On Mon, Aug 4, 2014 at 2:39 PM, <mailto:nightlyone@googlemail.com> wrote:
> 
> > On Monday, August 4, 2014 8:14:11 PM UTC+2, mailto:g...@golang.org wrote:
> > > What's the rationale for this change?
> >
> > I would guess the missing concept of uppercase/lowercase in several
> > languages as illustrated here: http://play.golang.org/p/5D2mHu2F7S
> >
> > https://codereview.appspot.com/121040043/
> >

Fixed.

[esk, 2014-08-05 03:29:29]

I've realized that I don't have enough (any) information about how this change
interacts with comments written in languages other than English. It could make
godoc worse: it's better to format headings as sentences than to format
sentences as headings. Please ignore this CL.

[gri, 2014-08-05 04:07:34]

np. Thanks for being diligent.
- gri


On Mon, Aug 4, 2014 at 8:29 PM, <evankroske@google.com> wrote:

> I've realized that I don't have enough (any) information about how this
> change interacts with comments written in languages other than English.
> It could make godoc worse: it's better to format headings as sentences
> than to format sentences as headings. Please ignore this CL.
>
> https://codereview.appspot.com/121040043/
>

[esk, 2014-08-08 03:23:38]

*** Abandoned ***