Issue 120610043: code review 120610043: cmd/cgo: fix handling of defs_linux.go

Issue 120610043: code review 120610043: cmd/cgo: fix handling of defs_linux.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by mdempsky

Modified:
10 years, 7 months ago

Reviewers:
gobot, iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

cmd/cgo: fix handling of defs_linux.go Instead of including <sys/types.h> to get size_t, instead include the ISO C standard <stddef.h> header, which defines fewer additional types at risk of colliding with the user code. In particular, this prevents collisions between <sys/types.h>'s userspace definitions with the kernel definitions needed by defs_linux.go. Also, -cdefs mode uses #pragma pack, so we can keep misaligned fields. Fixes issue 8477.

Patch Set 1 #

Patch Set 2 : diff -r 88999b670ed9 https://code.google.com/p/go #

Patch Set 3 : diff -r 88999b670ed9 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 88999b670ed9 https://code.google.com/p/go #

Patch Set 5 : diff -r 88999b670ed9 https://code.google.com/p/go #

Patch Set 6 : diff -r 88999b670ed9 https://code.google.com/p/go #

Patch Set 7 : diff -r 88999b670ed9 https://code.google.com/p/go #

Patch Set 8 : diff -r 88999b670ed9 https://code.google.com/p/go #

Patch Set 9 : diff -r ed83901ff17e https://code.google.com/p/go #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -9 lines)			Patch
M	misc/cgo/testcdefs/cdefstest.c	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	misc/cgo/testcdefs/cdefstest.go	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	misc/cgo/testcdefs/main.c	View	2 chunks	+23 lines, -0 lines	0 comments	Download
M	src/cmd/cgo/gcc.go	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/cmd/cgo/out.go	View	1 chunk	+2 lines, -8 lines	0 comments	Download
M	src/pkg/runtime/defs_linux.go	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 10

Expand All Messages | Collapse All Messages

mdempsky

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 7 months ago (2014-08-05 21:09:28 UTC) #1

mdempsky

https://codereview.appspot.com/120610043/diff/40001/src/cmd/cgo/out.go File src/cmd/cgo/out.go (right): https://codereview.appspot.com/120610043/diff/40001/src/cmd/cgo/out.go#newcode1155 src/cmd/cgo/out.go:1155: typedef __PTRDIFF_TYPE__ intgo; Since <stddef.h> will provide __PTRDIFF_TYPE__ as ...

10 years, 7 months ago (2014-08-05 21:16:33 UTC) #2

iant

On 2014/08/05 21:16:33, mdempsky wrote: > https://codereview.appspot.com/120610043/diff/40001/src/cmd/cgo/out.go > File src/cmd/cgo/out.go (right): > > https://codereview.appspot.com/120610043/diff/40001/src/cmd/cgo/out.go#newcode1155 > ...

10 years, 7 months ago (2014-08-06 00:32:05 UTC) #3

mdempsky

On 2014/08/06 00:32:05, iant wrote: > typedef ptrdiff_t intgo; > > sounds good to me. ...

10 years, 7 months ago (2014-08-06 00:36:52 UTC) #4

mdempsky

On 2014/08/06 01:02:20, iant wrote: > Can you sync your tree and "hg upload 120610043"? ...

10 years, 7 months ago (2014-08-06 01:07:04 UTC) #7

iant

*** Submitted as https://code.google.com/p/go/source/detail?r=f56df0219bda *** cmd/cgo: fix handling of defs_linux.go Instead of including <sys/types.h> to ...

10 years, 7 months ago (2014-08-06 01:12:40 UTC) #8

gobot

This CL appears to have broken the openbsd-386-rootbsd builder. See http://build.golang.org/log/3777a09f70084d189c795727d16d90ebc8da2259

10 years, 7 months ago (2014-08-06 02:44:36 UTC) #9

iant

10 years, 7 months ago (2014-08-06 03:53:45 UTC) #10

On Tue, Aug 5, 2014 at 7:44 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the openbsd-386-rootbsd builder.
> See http://build.golang.org/log/3777a09f70084d189c795727d16d90ebc8da2259
>
> https://codereview.appspot.com/120610043/

I don't think so.

panic: test timed out after 2m0s

goroutine 40723 [running]:
runtime.panic(0x81b0160, 0x18526230)
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/panic.c:278
+0xc5
testing.func·008()
/usr/local/go/src/pkg/testing/testing.go:634 +0xc8
created by time.goFunc
/usr/local/go/src/pkg/time/sleep.go:121 +0x44

goroutine 1 [chan receive, 295944 minutes]:
testing.RunTests(0x8253568, 0x8322100, 0x69, 0x69, 0x1)
/usr/local/go/src/pkg/testing/testing.go:510 +0x756
testing.Main(0x8253568, 0x8322100, 0x69, 0x69, 0x8323160, 0xc2, 0xc2,
0x83276a0, 0x0, 0x0)
/usr/local/go/src/pkg/testing/testing.go:440 +0x68
main.main()
runtime/_test/_testmain.go:643 +0x80

goroutine 4 [finalizer wait]:
runtime.park(0x80631e0, 0x832453c, 0x8322f67)
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/proc.c:1406
+0x7c
runtime.parkunlock(0x832453c, 0x8322f67)
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/proc.c:1422
+0x39
runfinq()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/mgc0.c:1649
+0xb9
runtime.goexit()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/proc.c:1475

goroutine 40988 [runnable]:
runtime_test.func·046()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:254
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:258
+0x19c

goroutine 40981 [runnable]:
runtime_test.func·048()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:267
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:274
+0x21a

goroutine 40989 [runnable]:
runtime_test.func·047()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:259
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:264
+0x1d1

goroutine 41007 [runnable]:
runtime_test.func·047()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:259
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:264
+0x1d1

goroutine 40998 [runnable]:
runtime_test.func·047()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:259
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:264
+0x1d1

goroutine 41000 [runnable]:
runtime_test.func·046()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:254
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:258
+0x19c

goroutine 40999 [runnable]:
runtime_test.func·048()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:267
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:274
+0x21a

goroutine 41004 [runnable]:
runtime_test.func·047()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:259
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:264
+0x1d1

goroutine 40994 [runnable]:
runtime_test.func·046()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:254
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:258
+0x19c

goroutine 32460 [semacquire]:
sync.runtime_Semacquire(0x18ad2b74)
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/sema.goc:199
+0x31
sync.(*WaitGroup).Wait(0x1850a580)
/usr/local/go/src/pkg/sync/waitgroup.go:129 +0x127
runtime_test.testConcurrentReadsAfterGrowth(0x18568480, 0x8324c01)
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:277
+0x23d
runtime_test.TestConcurrentReadsAfterGrowthReflect(0x18568480)
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:287
+0x2d
testing.tRunner(0x18568480, 0x8322394)
/usr/local/go/src/pkg/testing/testing.go:427 +0x81
created by testing.RunTests
/usr/local/go/src/pkg/testing/testing.go:509 +0x71a

goroutine 41011 [runnable]:
runtime_test.func·048()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:267
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:274
+0x21a

goroutine 40992 [runnable]:
runtime_test.func·047()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:259
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:264
+0x1d1

goroutine 40979 [runnable]:
runtime_test.func·046()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:254
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:258
+0x19c

goroutine 41001 [runnable]:
runtime_test.func·047()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:259
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:264
+0x1d1

goroutine 40991 [runnable]:
runtime_test.func·046()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:254
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:258
+0x19c

goroutine 41006 [runnable]:
runtime_test.func·046()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:254
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:258
+0x19c

goroutine 40990 [runnable]:
runtime_test.func·048()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:267
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:274
+0x21a

goroutine 40982 [runnable]:
runtime_test.func·046()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:254
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:258
+0x19c

goroutine 40995 [runnable]:
runtime_test.func·047()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:259
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:264
+0x1d1

goroutine 40986 [runnable]:
runtime_test.func·047()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:259
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:264
+0x1d1

goroutine 40997 [runnable]:
runtime_test.func·046()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:254
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:258
+0x19c

goroutine 40996 [runnable]:
runtime_test.func·048()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:267
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:274
+0x21a

goroutine 40977 [runnable]:
runtime_test.func·047()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:259
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:264
+0x1d1

goroutine 40978 [runnable]:
runtime_test.func·048()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:267
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:274
+0x21a

goroutine 40983 [runnable]:
runtime_test.func·047()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:259
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:264
+0x1d1

goroutine 40975 [runnable]:
runtime_test.func·048()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:267
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:274
+0x21a

goroutine 41008 [runnable]:
runtime_test.func·048()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:267
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:274
+0x21a

goroutine 40980 [runnable]:
runtime_test.func·047()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:259
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:264
+0x1d1

goroutine 40984 [runnable]:
runtime_test.func·048()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:267
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:274
+0x21a

goroutine 40974 [runnable]:
runtime_test.func·047()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:259
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:264
+0x1d1

goroutine 41003 [runnable]:
runtime_test.func·046()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:254
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:258
+0x19c

goroutine 41009 [runnable]:
runtime_test.func·046()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:254
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:258
+0x19c

goroutine 41005 [runnable]:
runtime_test.func·048()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:267
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:274
+0x21a

goroutine 40987 [runnable]:
runtime_test.func·048()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:267
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:274
+0x21a

goroutine 40985 [runnable]:
runtime_test.func·046()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:254
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:258
+0x19c

goroutine 40976 [runnable]:
runtime_test.func·046()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:254
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:258
+0x19c

goroutine 41010 [runnable]:
runtime_test.func·047()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:259
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:264
+0x1d1

goroutine 41002 [runnable]:
runtime_test.func·048()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:267
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:274
+0x21a

goroutine 40993 [runnable]:
runtime_test.func·048()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:267
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:274
+0x21a

goroutine 40973 [runnable]:
runtime_test.func·046()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:254
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:258
+0x19c

goroutine 40972 [runnable]:
reflect.Value.pointer(0x81b0720, 0x18626a60, 0x0, 0x150, 0x821d9a8)
/usr/local/go/src/pkg/reflect/value.go:114
reflect.Value.MapIndex(0x81b0720, 0x18626a60, 0x0, 0x150, 0x81afea0,
0x0, 0x29, 0x20, 0x0, 0x0, ...)
/usr/local/go/src/pkg/reflect/value.go:1205 +0xe0
runtime_test.func·048()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:272
+0x119
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:274
+0x21a

goroutine 41013 [runnable]:
runtime_test.func·047()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:259
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:264
+0x1d1

goroutine 41012 [runnable]:
runtime_test.func·046()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:254
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:258
+0x19c

goroutine 41014 [runnable]:
runtime_test.func·048()
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:267
created by runtime_test.testConcurrentReadsAfterGrowth
/home/gopher/gobuilder/openbsd-386-rootbsd-f56df0219bda/go/src/pkg/runtime/map_test.go:274
+0x21a
FAIL runtime 120.453s

Expand All Messages | Collapse All Messages