Issue 12006047: code review 12006047: text/template/parse: print TextNodes using %s not %q

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12006047: code review 12006047: text/template/parse: print TextNodes using %s not %q (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by r

Modified:
11 years, 7 months ago

Reviewers:
dsymonds

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

text/template/parse: print TextNodes using %s not %q This means that printing a Node will produce output that can be used as valid input. It won't be exactly the same - some spacing may be different - but it will mean the same. Fixes issue 4593.

Patch Set 1 #

Patch Set 2 : diff -r 2f6ebc31b696 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 0d2398504967 https://code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
M	src/pkg/text/template/multi_test.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/text/template/parse/node.go	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	src/pkg/text/template/parse/parse_test.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 7 months ago (2013-07-31 04:08:00 UTC) #1

11 years, 7 months ago (2013-07-31 05:09:21 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=cd0bae7395e8 ***

text/template/parse: print TextNodes using %s not %q
This means that printing a Node will produce output that can be used as valid
input.
It won't be exactly the same - some spacing may be different - but it will mean
the same.

Fixes issue 4593.

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/12006047

Expand All Messages | Collapse All Messages