Issue 12003043: code review 12003043: go.talks: add build tags to 2013 OSCON talks.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12003043: code review 12003043: go.talks: add build tags to 2013 OSCON talks. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by dsymonds

Modified:
10 years, 9 months ago

Reviewers:
adg

CC:
adg, golang-dev

Visibility:
Public.

Description

go.talks: add build tags to 2013 OSCON talks.

Patch Set 1 #

Patch Set 2 : diff -r 4b257899b8d1 https://code.google.com/p/go.talks #

Patch Set 3 : diff -r 4b257899b8d1 https://code.google.com/p/go.talks #

Patch Set 4 : diff -r 4b257899b8d1 https://code.google.com/p/go.talks #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -0 lines)			Patch
M	2013/bestpractices/bufchan.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	2013/bestpractices/bufchanfix.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	2013/bestpractices/concurrency1.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	2013/bestpractices/concurrency2.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	2013/bestpractices/httphandler.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	2013/bestpractices/quitchan.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	2013/bestpractices/server.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	2013/bestpractices/shortercode1.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	2013/bestpractices/shortercode2.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	2013/bestpractices/shortercode3.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	2013/bestpractices/shortercode4.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	2013/bestpractices/shortercode5.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	2013/oscon-dl/after.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	2013/oscon-dl/chunkaligned.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	2013/oscon-dl/copy.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	2013/oscon-dl/groupcache.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	2013/oscon-dl/server.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	2013/oscon-dl/server-compose.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	2013/oscon-dl/server-content.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	2013/oscon-dl/server-fs.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	2013/oscon-dl/server-hello.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	2013/oscon-dl/sizereaderat.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks

10 years, 9 months ago (2013-07-29 03:04:40 UTC) #1

dsymonds

10 years, 9 months ago (2013-07-29 03:08:58 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=2378df072d62&repo=talks ***

go.talks: add build tags to 2013 OSCON talks.

R=adg
CC=golang-dev
https://codereview.appspot.com/12003043

Expand All Messages | Collapse All Messages