Issue 12002043: code review 12002043: [release-branch.go1.1] bufio: check buffer availability...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12002043: code review 12002043: [release-branch.go1.1] bufio: check buffer availability... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by adg

Modified:
10 years, 9 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

[release-branch.go1.1] bufio: check buffer availability before reading in ReadFrom This change was applied by hand, as bufio has seen some refactoring since 1.1 was branched. The only difference between this and the original patch is the offset of the change, and s/flush/Flush/. ««« CL 11801043 / 3ffbc06b4874 bufio: check buffer availability before reading in ReadFrom Fixes issue 5947 . R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/11801043 »»» Update issue 5928

Patch Set 1 #

Patch Set 2 : diff -r 55ac276af5a7 https://code.google.com/p/go #

Patch Set 3 : diff -r 55ac276af5a7 https://code.google.com/p/go #

Patch Set 4 : diff -r 55ac276af5a7 https://code.google.com/p/go #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -6 lines)			Patch
	M	src/pkg/bufio/bufio.go	View	1 2	1 chunk	+11 lines, -6 lines	0 comments	Download
	M	src/pkg/bufio/bufio_test.go	View	1	2 chunks	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 9 months ago (2013-07-29 01:59:40 UTC) #1

adg

10 years, 9 months ago (2013-07-29 08:01:07 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=a6a9792f94ac ***

[release-branch.go1.1] bufio: check buffer availability before reading in
ReadFrom

This change was applied by hand, as bufio has seen some refactoring
since 1.1 was branched. The only difference between this and the
original patch is the offset of the change, and s/flush/Flush/.

««« CL 11801043 / 3ffbc06b4874
bufio: check buffer availability before reading in ReadFrom

Fixes  issue 5947 .

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/11801043
»»»

Update issue 5928

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/12002043

Expand All Messages | Collapse All Messages