Issue 12001056: code review 12001056: path/filepath: Panic in Match when parsing invalid char...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12001056: code review 12001056: path/filepath: Panic in Match when parsing invalid char... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by peted

Modified:
10 years, 9 months ago

Reviewers:
r

CC:
golang-dev, rsc, r

Visibility:
Public.

Description

path/filepath: Panic in Match when parsing invalid character range. Fixes issue 5668.

Patch Set 1 #

Patch Set 2 : diff -r 521dd78cd28e https://code.google.com/p/go #

Patch Set 3 : diff -r 521dd78cd28e https://code.google.com/p/go #

Patch Set 4 : diff -r 521dd78cd28e https://code.google.com/p/go #

Patch Set 5 : diff -r 521dd78cd28e https://code.google.com/p/go #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
M	src/pkg/path/filepath/match.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/pkg/path/filepath/match_test.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/pkg/path/match_test.go	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

peted

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 9 months ago (2013-07-30 22:21:09 UTC) #1

peted

On 2013/07/31 00:09:55, rsc wrote: > does package path need the same fix? Surprisingly, no. ...

10 years, 9 months ago (2013-07-31 00:17:50 UTC) #3

peted

Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

10 years, 9 months ago (2013-07-31 00:18:39 UTC) #4

10 years, 9 months ago (2013-07-31 06:58:37 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=19bc695d0c39 ***

path/filepath: Panic in Match when parsing invalid character range.

Fixes issue 5668.

R=golang-dev, rsc, r
CC=golang-dev
https://codereview.appspot.com/12001056

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages