Issue 12001043: code review 12001043: misc/dashboard: don't update tip tag for release branch...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12001043: code review 12001043: misc/dashboard: don't update tip tag for release branch... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by dsymonds

Modified:
11 years, 8 months ago

Reviewers:
adg

CC:
golang-dev, adg

Visibility:
Public.

Description

misc/dashboard: don't update tip tag for release branch commits. This will mean that sub-repositories won't get built against the release branch. They are often not compatible because the subrepos often run ahead of the current release (e.g. go.tools is using new additions to go/ast, and go.net is using new things in syscall) so there's little point in checking them against cherrypick commits when they'll be tested against those commits on tip anyway.

Patch Set 1 #

Patch Set 2 : diff -r e6a6dc0d9c22 https://code.google.com/p/go #

Patch Set 3 : diff -r 87fd884c846b https://code.google.com/p/go #

Patch Set 4 : diff -r 87fd884c846b https://code.google.com/p/go #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	misc/dashboard/app/build/handler.go	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 8 months ago (2013-07-29 01:40:21 UTC) #1

dsymonds

11 years, 8 months ago (2013-07-29 02:08:26 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=9e46fca8567b ***

misc/dashboard: don't update tip tag for release branch commits.

This will mean that sub-repositories won't get built against the
release branch. They are often not compatible because the subrepos
often run ahead of the current release (e.g. go.tools is using
new additions to go/ast, and go.net is using new things in syscall)
so there's little point in checking them against cherrypick commits
when they'll be tested against those commits on tip anyway.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/12001043

Expand All Messages | Collapse All Messages